apollo_propeller: rename shard_count to unit_count in should_build and should_receive#13531
Conversation
This was referenced Mar 26, 2026
Merged
Merged
Merged
Open
Open
This was referenced Mar 26, 2026
This was referenced Apr 6, 2026
Draft
apollo_propeller: rename shard_index params and test case names to unit_index in tree_test.rs
#13591
Draft
Draft
d2e59c6 to
5799d4f
Compare
c2c58f9 to
1296497
Compare
5799d4f to
a4e4e36
Compare
2f78410 to
f6c9d26
Compare
e60feec to
c1b8b96
Compare
f6c9d26 to
ba71fe5
Compare
c1b8b96 to
6fdaee3
Compare
ba71fe5 to
226d12a
Compare
PR SummaryLow Risk Overview Reviewed by Cursor Bugbot for commit cea441d. Bugbot is set up for automated code reviews on this repo. Configure here. |
6fdaee3 to
cea441d
Compare
…ard' for PropellerUnit
65ad22c to
aabf559
Compare
cea441d to
69a5650
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
Low risk: this is a parameter rename in
should_build/should_receivewith no behavioral change, only minor potential for downstream compile fixes if any callers relied on naming semantics.Overview
Renames the
should_build/should_receivethreshold parameter fromshard_counttounit_countinPropellerScheduleManager, aligning terminology with “units received” while keeping the same threshold logic.Reviewed by Cursor Bugbot for commit c1b8b96. Bugbot is set up for automated code reviews on this repo. Configure here.