Skip to content

apollo_propeller: rename shard_count to unit_count in should_build and should_receive#13531

Open
sirandreww-starkware wants to merge 1 commit into03-26-apollo_propeller_fix_propellerschedulemanager_doc_comments_to_say_units_from
03-26-apollo_propeller_rename_shard_count_to_unit_count_in_should_build_and_should_receive
Open

apollo_propeller: rename shard_count to unit_count in should_build and should_receive#13531
sirandreww-starkware wants to merge 1 commit into03-26-apollo_propeller_fix_propellerschedulemanager_doc_comments_to_say_units_from
03-26-apollo_propeller_rename_shard_count_to_unit_count_in_should_build_and_should_receive

Conversation

@sirandreww-starkware
Copy link
Copy Markdown
Contributor

@sirandreww-starkware sirandreww-starkware commented Mar 26, 2026

Note

Low Risk
Low risk: this is a parameter rename in should_build/should_receive with no behavioral change, only minor potential for downstream compile fixes if any callers relied on naming semantics.

Overview
Renames the should_build/should_receive threshold parameter from shard_count to unit_count in PropellerScheduleManager, aligning terminology with “units received” while keeping the same threshold logic.

Reviewed by Cursor Bugbot for commit c1b8b96. Bugbot is set up for automated code reviews on this repo. Configure here.

This was referenced Mar 26, 2026
@sirandreww-starkware sirandreww-starkware self-assigned this Mar 26, 2026
@sirandreww-starkware sirandreww-starkware force-pushed the 03-26-apollo_propeller_rename_shard_count_to_unit_count_in_should_build_and_should_receive branch from d2e59c6 to 5799d4f Compare April 6, 2026 07:15
@sirandreww-starkware sirandreww-starkware force-pushed the 03-26-apollo_propeller_fix_propellerschedulemanager_doc_comments_to_say_units_ branch from c2c58f9 to 1296497 Compare April 6, 2026 07:15
@sirandreww-starkware sirandreww-starkware force-pushed the 03-26-apollo_propeller_rename_shard_count_to_unit_count_in_should_build_and_should_receive branch from 5799d4f to a4e4e36 Compare April 6, 2026 08:35
@sirandreww-starkware sirandreww-starkware force-pushed the 03-26-apollo_propeller_fix_propellerschedulemanager_doc_comments_to_say_units_ branch 2 times, most recently from 2f78410 to f6c9d26 Compare April 6, 2026 12:03
@sirandreww-starkware sirandreww-starkware force-pushed the 03-26-apollo_propeller_rename_shard_count_to_unit_count_in_should_build_and_should_receive branch 2 times, most recently from e60feec to c1b8b96 Compare April 6, 2026 13:25
@sirandreww-starkware sirandreww-starkware force-pushed the 03-26-apollo_propeller_fix_propellerschedulemanager_doc_comments_to_say_units_ branch from f6c9d26 to ba71fe5 Compare April 6, 2026 13:25
@sirandreww-starkware sirandreww-starkware force-pushed the 03-26-apollo_propeller_rename_shard_count_to_unit_count_in_should_build_and_should_receive branch from c1b8b96 to 6fdaee3 Compare April 20, 2026 05:57
@sirandreww-starkware sirandreww-starkware force-pushed the 03-26-apollo_propeller_fix_propellerschedulemanager_doc_comments_to_say_units_ branch from ba71fe5 to 226d12a Compare April 20, 2026 05:57
@cursor
Copy link
Copy Markdown

cursor Bot commented Apr 20, 2026

PR Summary

Low Risk
Parameter rename only; logic and thresholds are unchanged, so runtime risk is minimal beyond basic compilation/usage updates.

Overview
Renames the should_build/should_receive argument from shard_count to unit_count in PropellerScheduleManager to better reflect that these thresholds are based on received units (data/coding), not strictly shards. No behavior changes; call sites continue to pass received_units.len()/num_held_units unchanged.

Reviewed by Cursor Bugbot for commit cea441d. Bugbot is set up for automated code reviews on this repo. Configure here.

@sirandreww-starkware sirandreww-starkware force-pushed the 03-26-apollo_propeller_rename_shard_count_to_unit_count_in_should_build_and_should_receive branch from 6fdaee3 to cea441d Compare April 20, 2026 09:54
@sirandreww-starkware sirandreww-starkware force-pushed the 03-26-apollo_propeller_fix_propellerschedulemanager_doc_comments_to_say_units_ branch from 65ad22c to aabf559 Compare April 23, 2026 07:52
@sirandreww-starkware sirandreww-starkware force-pushed the 03-26-apollo_propeller_rename_shard_count_to_unit_count_in_should_build_and_should_receive branch from cea441d to 69a5650 Compare April 23, 2026 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants