apollo_propeller: rename shards param to units in reconstruct_blocking#13527
Conversation
This was referenced Mar 26, 2026
This was referenced Mar 26, 2026
Merged
This was referenced Mar 26, 2026
Merged
Open
This was referenced Apr 6, 2026
Draft
apollo_propeller: rename shard_index params and test case names to unit_index in tree_test.rs
#13591
Draft
Draft
09763a5 to
1185f25
Compare
53bbc9a to
1f03831
Compare
1185f25 to
ec3f449
Compare
1f03831 to
de900bc
Compare
5ed2d9e to
70d99d3
Compare
guy-starkware
approved these changes
Apr 9, 2026
Contributor
guy-starkware
left a comment
There was a problem hiding this comment.
@guy-starkware reviewed 1 file and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on noamsp-starkware and ShahakShama).
2c45eb7 to
f1d0b0c
Compare
70d99d3 to
1261fbb
Compare
PR SummaryLow Risk Overview No functional behavior changes; this is a naming/clarity tweak to better reflect that the function operates on Reviewed by Cursor Bugbot for commit d629c4b. Bugbot is set up for automated code reviews on this repo. Configure here. |
1261fbb to
d629c4b
Compare
…ard' for PropellerUnit
6aa18db to
c907d5b
Compare
d629c4b to
3d555cf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
Low risk: a pure parameter rename in
MessageProcessor::reconstruct_blockingwith no behavioral or data-flow changes.Overview
Renames the
reconstruct_blockingargument fromshardstounitsinmessage_processor.rsto better matchPropellerUnitterminology, updating the internal call toreconstruct_data_shardsaccordingly.Reviewed by Cursor Bugbot for commit 70d99d3. Bugbot is set up for automated code reviews on this repo. Configure here.