Skip to content

apollo_propeller: rename shards param to units in reconstruct_blocking#13527

Open
sirandreww-starkware wants to merge 1 commit into03-26-apollo_propeller_fix_postconstruction_doc_comment_to_say_units_from
03-26-apollo_propeller_rename_shards_param_to_units_in_reconstruct_blocking
Open

apollo_propeller: rename shards param to units in reconstruct_blocking#13527
sirandreww-starkware wants to merge 1 commit into03-26-apollo_propeller_fix_postconstruction_doc_comment_to_say_units_from
03-26-apollo_propeller_rename_shards_param_to_units_in_reconstruct_blocking

Conversation

@sirandreww-starkware
Copy link
Copy Markdown
Contributor

@sirandreww-starkware sirandreww-starkware commented Mar 26, 2026

Note

Low Risk
Low risk: a pure parameter rename in MessageProcessor::reconstruct_blocking with no behavioral or data-flow changes.

Overview
Renames the reconstruct_blocking argument from shards to units in message_processor.rs to better match PropellerUnit terminology, updating the internal call to reconstruct_data_shards accordingly.

Reviewed by Cursor Bugbot for commit 70d99d3. Bugbot is set up for automated code reviews on this repo. Configure here.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

@sirandreww-starkware sirandreww-starkware self-assigned this Mar 26, 2026
@sirandreww-starkware sirandreww-starkware marked this pull request as ready for review March 26, 2026 16:00
@sirandreww-starkware sirandreww-starkware force-pushed the 03-26-apollo_propeller_rename_shards_param_to_units_in_reconstruct_blocking branch from 09763a5 to 1185f25 Compare April 6, 2026 07:15
@sirandreww-starkware sirandreww-starkware force-pushed the 03-26-apollo_propeller_fix_postconstruction_doc_comment_to_say_units_ branch from 53bbc9a to 1f03831 Compare April 6, 2026 07:15
@sirandreww-starkware sirandreww-starkware force-pushed the 03-26-apollo_propeller_rename_shards_param_to_units_in_reconstruct_blocking branch from 1185f25 to ec3f449 Compare April 6, 2026 08:35
@sirandreww-starkware sirandreww-starkware force-pushed the 03-26-apollo_propeller_fix_postconstruction_doc_comment_to_say_units_ branch from 1f03831 to de900bc Compare April 6, 2026 08:35
@sirandreww-starkware sirandreww-starkware force-pushed the 03-26-apollo_propeller_rename_shards_param_to_units_in_reconstruct_blocking branch 2 times, most recently from 5ed2d9e to 70d99d3 Compare April 6, 2026 13:25
Copy link
Copy Markdown
Contributor

@guy-starkware guy-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guy-starkware reviewed 1 file and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on noamsp-starkware and ShahakShama).

@sirandreww-starkware sirandreww-starkware changed the base branch from 03-26-apollo_propeller_fix_postconstruction_doc_comment_to_say_units_ to graphite-base/13527 April 9, 2026 13:08
@sirandreww-starkware sirandreww-starkware force-pushed the 03-26-apollo_propeller_rename_shards_param_to_units_in_reconstruct_blocking branch from 70d99d3 to 1261fbb Compare April 20, 2026 05:57
@cursor
Copy link
Copy Markdown

cursor Bot commented Apr 20, 2026

PR Summary

Low Risk
Purely a local variable rename with no logic changes, so regression risk is minimal.

Overview
Renames the reconstruct_blocking parameter from shards to units in message_processor.rs, updating the call into reconstruct_data_shards accordingly.

No functional behavior changes; this is a naming/clarity tweak to better reflect that the function operates on PropellerUnits.

Reviewed by Cursor Bugbot for commit d629c4b. Bugbot is set up for automated code reviews on this repo. Configure here.

@sirandreww-starkware sirandreww-starkware changed the base branch from graphite-base/13527 to 03-26-apollo_propeller_fix_postconstruction_doc_comment_to_say_units_ April 20, 2026 05:57
@sirandreww-starkware sirandreww-starkware force-pushed the 03-26-apollo_propeller_rename_shards_param_to_units_in_reconstruct_blocking branch from 1261fbb to d629c4b Compare April 20, 2026 09:54
@sirandreww-starkware sirandreww-starkware force-pushed the 03-26-apollo_propeller_fix_postconstruction_doc_comment_to_say_units_ branch from 6aa18db to c907d5b Compare April 23, 2026 07:52
@sirandreww-starkware sirandreww-starkware force-pushed the 03-26-apollo_propeller_rename_shards_param_to_units_in_reconstruct_blocking branch from d629c4b to 3d555cf Compare April 23, 2026 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants