Skip to content

apollo_propeller: rename shard_count/total_shards to unit_count/total_units#13528

Open
sirandreww-starkware wants to merge 1 commit into03-26-apollo_propeller_rename_shards_param_to_units_in_reconstruct_blockingfrom
03-26-apollo_propeller_rename_shard_count_total_shards_to_unit_count_total_units_in_handle_reconstruction_output
Open

apollo_propeller: rename shard_count/total_shards to unit_count/total_units#13528
sirandreww-starkware wants to merge 1 commit into03-26-apollo_propeller_rename_shards_param_to_units_in_reconstruct_blockingfrom
03-26-apollo_propeller_rename_shard_count_total_shards_to_unit_count_total_units_in_handle_reconstruction_output

Conversation

@sirandreww-starkware
Copy link
Copy Markdown
Contributor

@sirandreww-starkware sirandreww-starkware commented Mar 26, 2026

Note

Low Risk
Low risk rename-only change that updates variable/parameter names used to track held items during reconstruction and emit-threshold logic; no behavioral changes intended.

Overview
Renames reconstruction counter variables in MessageProcessor::handle_reconstruction_output from shard_count/total_shards to unit_count/total_units to better reflect that the code is counting units held (including an optional self-broadcast) when transitioning to PostConstruction.

Reviewed by Cursor Bugbot for commit e7267fc. Bugbot is set up for automated code reviews on this repo. Configure here.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

@sirandreww-starkware sirandreww-starkware self-assigned this Mar 26, 2026
@sirandreww-starkware sirandreww-starkware marked this pull request as ready for review March 26, 2026 16:00
@sirandreww-starkware sirandreww-starkware force-pushed the 03-26-apollo_propeller_rename_shard_count_total_shards_to_unit_count_total_units_in_handle_reconstruction_output branch from 3fa1ac5 to e326b54 Compare April 6, 2026 07:15
@sirandreww-starkware sirandreww-starkware force-pushed the 03-26-apollo_propeller_rename_shards_param_to_units_in_reconstruct_blocking branch from 1185f25 to ec3f449 Compare April 6, 2026 08:35
@sirandreww-starkware sirandreww-starkware force-pushed the 03-26-apollo_propeller_rename_shard_count_total_shards_to_unit_count_total_units_in_handle_reconstruction_output branch from e326b54 to 6b403ba Compare April 6, 2026 08:35
@sirandreww-starkware sirandreww-starkware force-pushed the 03-26-apollo_propeller_rename_shards_param_to_units_in_reconstruct_blocking branch from ec3f449 to 5ed2d9e Compare April 6, 2026 12:03
@sirandreww-starkware sirandreww-starkware force-pushed the 03-26-apollo_propeller_rename_shard_count_total_shards_to_unit_count_total_units_in_handle_reconstruction_output branch 2 times, most recently from 3bd5d80 to e7267fc Compare April 6, 2026 13:25
Copy link
Copy Markdown
Contributor

@guy-starkware guy-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guy-starkware reviewed 1 file and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on noamsp-starkware and ShahakShama).

@sirandreww-starkware sirandreww-starkware force-pushed the 03-26-apollo_propeller_rename_shard_count_total_shards_to_unit_count_total_units_in_handle_reconstruction_output branch from e7267fc to 18f802b Compare April 20, 2026 05:57
@sirandreww-starkware sirandreww-starkware force-pushed the 03-26-apollo_propeller_rename_shards_param_to_units_in_reconstruct_blocking branch from 70d99d3 to 1261fbb Compare April 20, 2026 05:57
@cursor
Copy link
Copy Markdown

cursor Bot commented Apr 20, 2026

PR Summary

Low Risk
Purely a naming/clarity change in message reconstruction state transitions with no behavioral or protocol changes.

Overview
Renames reconstruction bookkeeping in message_processor.rs from shard_count/total_shards to unit_count/total_units, clarifying that the post-reconstruction held-count is tracking units (including a possible locally reconstructed+rebroadcast unit) rather than raw shards.

Reviewed by Cursor Bugbot for commit 1cabacf. Bugbot is set up for automated code reviews on this repo. Configure here.

@sirandreww-starkware sirandreww-starkware force-pushed the 03-26-apollo_propeller_rename_shards_param_to_units_in_reconstruct_blocking branch from 1261fbb to d629c4b Compare April 20, 2026 09:54
@sirandreww-starkware sirandreww-starkware force-pushed the 03-26-apollo_propeller_rename_shard_count_total_shards_to_unit_count_total_units_in_handle_reconstruction_output branch from 18f802b to 1cabacf Compare April 20, 2026 09:54
@sirandreww-starkware sirandreww-starkware force-pushed the 03-26-apollo_propeller_rename_shard_count_total_shards_to_unit_count_total_units_in_handle_reconstruction_output branch from 1cabacf to 6f3cefc Compare April 23, 2026 07:52
@sirandreww-starkware sirandreww-starkware force-pushed the 03-26-apollo_propeller_rename_shards_param_to_units_in_reconstruct_blocking branch from d629c4b to 3d555cf Compare April 23, 2026 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants