apollo_propeller: rename shard_count/total_shards to unit_count/total_units#13528
Conversation
This was referenced Mar 26, 2026
This was referenced Mar 26, 2026
This was referenced Mar 26, 2026
Merged
Open
This was referenced Apr 6, 2026
Draft
apollo_propeller: rename shard_index params and test case names to unit_index in tree_test.rs
#13591
Draft
Draft
3fa1ac5 to
e326b54
Compare
1185f25 to
ec3f449
Compare
e326b54 to
6b403ba
Compare
ec3f449 to
5ed2d9e
Compare
3bd5d80 to
e7267fc
Compare
guy-starkware
approved these changes
Apr 9, 2026
Contributor
guy-starkware
left a comment
There was a problem hiding this comment.
@guy-starkware reviewed 1 file and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on noamsp-starkware and ShahakShama).
e7267fc to
18f802b
Compare
70d99d3 to
1261fbb
Compare
PR SummaryLow Risk Overview Reviewed by Cursor Bugbot for commit 1cabacf. Bugbot is set up for automated code reviews on this repo. Configure here. |
1261fbb to
d629c4b
Compare
18f802b to
1cabacf
Compare
…ard' for PropellerUnit
1cabacf to
6f3cefc
Compare
d629c4b to
3d555cf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
Low risk rename-only change that updates variable/parameter names used to track held items during reconstruction and emit-threshold logic; no behavioral changes intended.
Overview
Renames reconstruction counter variables in
MessageProcessor::handle_reconstruction_outputfromshard_count/total_shardstounit_count/total_unitsto better reflect that the code is counting units held (including an optional self-broadcast) when transitioning toPostConstruction.Reviewed by Cursor Bugbot for commit e7267fc. Bugbot is set up for automated code reviews on this repo. Configure here.