bugfix(lobby): Fix player list ignoring refresh interval on roster updates and adjust lobby entry animation

Core/GameEngine/Source/GameNetwork/GameSpy/LobbyUtils.cpp

@@ -109,7 +109,7 @@ static float UpdateAndGetGameRowIndex(int lobbyID, float logicalIndex)
     if (!anim.alive)
     {
         // start slightly below, then glide into place
-        anim.currentIndex = logicalIndex + 0.3f;
+        anim.currentIndex = logicalIndex + 2.f;
         anim.targetIndex  = logicalIndex;
         anim.alive        = true;
     }
@@ -119,33 +119,14 @@ static float UpdateAndGetGameRowIndex(int lobbyID, float logicalIndex)
     }
 
     // how fast to snap into place
-    const float t = 0.1f; 
+    const float t = 0.2f; 
 
     float delta = anim.targetIndex - anim.currentIndex;
     anim.currentIndex += delta * t;
 
     return anim.currentIndex;
 }
 
-// Clears animation state for IDs that no longer exist
-static void CleanupMissingGameRows(const std::vector<LobbyEntry>& lobbies)
-{
-	std::map<int, bool> stillPresent;
-
-	for (const LobbyEntry& lobby : lobbies)
-	{
-		stillPresent[lobby.lobbyID] = true;
-	}
-
-	for (auto it = g_gameListAnim.begin(); it != g_gameListAnim.end(); )
-	{
-		if (stillPresent.find(it->first) == stillPresent.end())
-			it = g_gameListAnim.erase(it);
-		else
-			++it;
-	}
-}
-
 static NameKeyType buttonSortAlphaID = NAMEKEY_INVALID;
 static NameKeyType buttonSortPingID = NAMEKEY_INVALID;
 static NameKeyType buttonSortBuddiesID = NAMEKEY_INVALID;

GeneralsMD/Code/GameEngine/Source/GameClient/GUI/GUICallbacks/Menus/WOLBuddyOverlay.cpp

@@ -598,7 +598,6 @@ void updateBuddyInfo( void )
                 //AsciiString strName;
 
                 int numUnreadMessages = 0;
-                NGMP_OnlineServices_SocialInterface* pSocialInterface = NGMP_OnlineServicesManager::GetInterface<NGMP_OnlineServices_SocialInterface>();
                 if (pSocialInterface != nullptr)
                 {
                     numUnreadMessages = pSocialInterface->GetNumberUnreadChatMessagesForUser(profileID);

GeneralsMD/Code/GameEngine/Source/GameClient/GUI/GUICallbacks/Menus/WOLLobbyMenu.cpp

@@ -90,7 +90,8 @@ static Bool raiseMessageBoxes = false;
 static time_t gameListRefreshTime = 0;
 static const time_t gameListRefreshInterval = 4000;
 static time_t playerListRefreshTime = 0;
-static const time_t playerListRefreshInterval = 4000;
+static const time_t playerListRefreshInterval = 6000;
+static bool isFirstRosterUpdate = false;
 
 void setUnignoreText( WindowLayout *layout, AsciiString nick, GPProfile id);
 static void doSliderTrack(GameWindow *control, Int val);
@@ -1247,6 +1248,7 @@ void WOLLobbyMenuInit( WindowLayout *layout, void *userData )
 	nextScreen = nullptr;
 	buttonPushed = false;
 	isShuttingDown = false;
+	isFirstRosterUpdate = true;
 
 	SetLobbyAttemptHostJoin(FALSE); // not trying to host or join
 
@@ -1344,7 +1346,15 @@ void WOLLobbyMenuInit( WindowLayout *layout, void *userData )
 		// register for roster events
 		pRoomsInterface->RegisterForRosterNeedsRefreshCallback([]()
 			{
-				refreshPlayerList(true);
+				if (isFirstRosterUpdate)
+				{
+					refreshPlayerList(true);
+					isFirstRosterUpdate = false;
+				}
+				else
+				{
+					refreshPlayerList(false);
+				}
 			});
 	}