bugfix(lobby): Fix player list ignoring refresh interval on roster updates and adjust lobby entry animation#426
Merged
x64-dev merged 1 commit intoGeneralsOnlineDevelopmentTeam:mainfrom Mar 27, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does a few minor bug fixes and tweaks here and there:
Fixes two issues with the lobby player list refresh behaviour.
The roster update callback was forcing an immediate refresh on every roster change and ignored the refresh interval, the player list was refreshing far more frequently than desired as result.
The fix allows a single forced refresh on lobby entry, then lets all later roster updates follow the normal interval.
Refresh interval is increased from 4 to 6 seconds to reduce unnecessary jumps on the player list and to allow for more time to read player's tooltip.
Cleans up redundancies and adjusts the row entry animation