fix(migration): add vitest to devDependencies for peer dep resolution#1261
Draft
fengmk2 wants to merge 1 commit intoreal-node-off-modefrom
Draft
fix(migration): add vitest to devDependencies for peer dep resolution#1261fengmk2 wants to merge 1 commit intoreal-node-off-modefrom
fengmk2 wants to merge 1 commit intoreal-node-off-modefrom
Conversation
Member
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd the label auto-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
fengmk2
force-pushed
the
fix-1256
branch
3 times, most recently
from
60480a3 to
cf88a62
Compare
When migrating projects that have packages with vitest as a peer dependency (e.g., vitest-browser-svelte), the migration now ensures vitest is added to devDependencies. Without this, pnpm resolves the real vitest@4.x for peer deps instead of the aliased @voidzero-dev/vite-plus-test, causing third-party type augmentations (like page.render() from vitest-browser-svelte) to target the wrong module and fail type checking. Also add vite-plus-vitest-type-aug reproduction project to ecosystem-ci for ongoing regression testing, and exclude build scripts from lint type checking. Closes #1256
fengmk2
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vitestin their name (e.g.,vitest-browser-svelte), the migration now addsvitesttodevDependencies. Without this, pnpm resolves the realvitest@4.xfor peer deps instead of the aliased@voidzero-dev/vite-plus-test, causing third-party type augmentations (likepage.render()fromvitest-browser-svelte) to target the wrong module and fail type checking.vite-plus-vitest-type-augreproduction project to ecosystem-ci for ongoing regression testing.migration-vitest-peer-depto verify the migration behavior.Test plan
migration-vitest-peer-depverifiesvitestis added to devDependencies whenvitest-browser-svelteis presentvite-plus-vitest-type-augpassesvp check --fixlocally with 0 type errorsCloses #1256
🤖 Generated with Claude Code