fix(migration): add vitest to devDependencies for peer dep resolution

When migrating projects that have packages with vitest as a peer
dependency (e.g., vitest-browser-svelte), the migration now ensures
vitest is added to devDependencies. Without this, pnpm resolves the
real vitest@4.x for peer deps instead of the aliased
@voidzero-dev/vite-plus-test, causing third-party type augmentations
(like page.render() from vitest-browser-svelte) to target the wrong
module and fail type checking.

Also add vite-plus-vitest-type-aug reproduction project to ecosystem-ci
for ongoing regression testing.

Closes #1256

Author: fengmk2

.github/workflows/e2e-test.yml

@@ -304,6 +304,10 @@ jobs:
             command: |
               npx playwright install chromium
               vp test
+          - name: vite-plus-vitest-type-aug
+            node-version: 24
+            command: |
+              vp check --fix
         exclude:
           # frm-stack uses Docker (testcontainers) which doesn't work the same way on Windows
           - os: windows-latest

ecosystem-ci/repo.json

@@ -113,5 +113,11 @@
     "repository": "https://github.com/why-reproductions-are-required/vitest-playwright-repro.git",
     "branch": "main",
     "hash": "f7252170025c01ec482fa9ad43e09b965f46928f"
+  },
+  "vite-plus-vitest-type-aug": {
+    "repository": "https://github.com/why-reproductions-are-required/vite-plus-vitest-type-aug.git",
+    "branch": "main",
+    "hash": "6192f60653c124ae068efaf5d7d0a4134c95edbd",
+    "forceFreshMigration": true
   }
 }

packages/cli/src/migration/migrator.ts

@@ -1399,6 +1399,16 @@ export function rewritePackageJson(
       ...pkg.devDependencies,
       [VITE_PLUS_NAME]: version,
     };
+    // Ensure vitest is in devDependencies so pnpm uses the override for peer dep
+    // resolution. Without this, packages like vitest-browser-svelte (peer dep:
+    // vitest ^4.0.0) resolve the real vitest instead of @voidzero-dev/vite-plus-test,
+    // causing third-party type augmentations to target the wrong module.
+    for (const [key, ver] of Object.entries(VITE_PLUS_OVERRIDE_PACKAGES)) {
+      if (!pkg.devDependencies[key] && !pkg.dependencies?.[key]) {
+        const overrideValue = supportCatalog && !ver.startsWith('file:') ? 'catalog:' : ver;
+        pkg.devDependencies[key] = overrideValue;
+      }
+    }
   }
   return extractedStagedConfig;
 }

packages/test/BUNDLING.md

@@ -309,6 +309,8 @@ When upgrading the vitest version:
     - createNodeEntry()          index-node.js with browser-provider
     - copyBrowserClientFiles()
     - createBrowserEntryFiles()  browser/ entry files at package root
+    - patchModuleAugmentations() Rewrite @vitest/expect, @vitest/runner augmentations
+    - patchChaiTypeReference()   Add @types/chai triple-slash reference
     - createPluginExports()      dist/plugins/* for pnpm overrides
     - mergePackageJson()
     - validateExternalDeps()

packages/test/build.ts

@@ -1,3 +1,4 @@
+/// <reference types="node" />
 // Build Script for @voidzero-dev/vite-plus-test
 //
 // Bundles vitest and @vitest/* dependencies with browser/Node.js separation.
@@ -175,7 +176,10 @@ const EXTERNAL_BLOCKLIST = new Set([
 const CJS_REEXPORT_PACKAGES = new Set(['expect-type']);
 
 // Node built-in modules (including node: prefix variants)
-const NODE_BUILTINS = new Set([...builtinModules, ...builtinModules.map((m) => `node:${m}`)]);
+const NODE_BUILTINS = new Set([
+  ...builtinModules,
+  ...builtinModules.map((m: string) => `node:${m}`),
+]);
 
 // Step 1: Copy vitest-dev dist files (rewriting vite -> core package)
 await bundleVitest();