Skip to content

fix(init): use bin.js entry point for TypeScript loader in justfile #1252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fengmk2 merged 3 commits into from
Apr 1, 2026
+1 −1
Merged

fix(init): use bin.js entry point for TypeScript loader in justfile #1252

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a932fa0
fix(init): use bin.js entry point for TypeScript loader in justfile
jong-kyung Apr 1, 2026
4ad1dc3
Merge branch 'main' into fix/just-init-module-not-found
jong-kyung Apr 1, 2026
27abf7d
Merge branch 'main' into fix/just-init-module-not-found
jong-kyung Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion justfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ _clean_dist:

init: _clean_dist
cargo binstall watchexec-cli cargo-insta typos-cli cargo-shear dprint taplo-cli -y
node packages/tools/src/index.ts sync-remote
node packages/tools/src/bin.js sync-remote
Copy link
Copy Markdown
Member

@fengmk2 fengmk2 Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jong-kyung This change will cause problems, as the "@oxc-node/core" dependency is not installed during the initialization phase. Since we declared that the node version supports running ts directly, the original node packages/tools/src/index.ts sync-remote is correct. I will revert this change first.

Copy link
Copy Markdown
Member

@fengmk2 fengmk2 Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know the reason for your modification. Tools should be changed to a pure TypeScript project. Let me refactor it.

Copy link
Copy Markdown
Contributor Author

@jong-kyung jong-kyung Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know the reason for your modification. Tools should be changed to a pure TypeScript project. Let me refactor it.

@fengmk2 Thanks for the explanation! I didn't consider that @oxc-node/core isn't available during the init phase. Looking forward to the refactor.

Copy link
Copy Markdown
Member

@fengmk2 fengmk2 Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1274

pnpm install
pnpm -C docs install

Expand Down
Loading