fix(init): use bin.js entry point for TypeScript loader in justfile#1252
Merged
fengmk2 merged 3 commits intovoidzero-dev:mainfrom Apr 1, 2026
Merged
Conversation
`just init` fails because `node packages/tools/src/index.ts` runs without a TypeScript loader, so Node.js cannot resolve `.js` imports to `.ts` files. Use `bin.js` which registers `@oxc-node/core/register` before importing `index.ts`.
✅ Deploy Preview for viteplus-preview canceled.
|
fengmk2
approved these changes
Apr 1, 2026
Member
|
@jong-kyung should merge changes from main branch first |
Contributor
Author
I've merged it! Thank you for reviewing |
fengmk2
reviewed
Apr 2, 2026
| init: _clean_dist | ||
| cargo binstall watchexec-cli cargo-insta typos-cli cargo-shear dprint taplo-cli -y | ||
| node packages/tools/src/index.ts sync-remote | ||
| node packages/tools/src/bin.js sync-remote |
Member
There was a problem hiding this comment.
@jong-kyung This change will cause problems, as the "@oxc-node/core" dependency is not installed during the initialization phase. Since we declared that the node version supports running ts directly, the original node packages/tools/src/index.ts sync-remote is correct. I will revert this change first.
Member
There was a problem hiding this comment.
I know the reason for your modification. Tools should be changed to a pure TypeScript project. Let me refactor it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1251
just initfails withERR_MODULE_NOT_FOUNDbecausenode packages/tools/src/index.tsruns without a TypeScript loader, so Node.js cannot resolve.jsimports to.tsfilesnode packages/tools/src/bin.jswhich registers@oxc-node/core/registerbefore importingindex.ts, enabling proper.js→.tsresolution