Skip to content

metrics: fall back to mockWriter on file open failure #608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SAY-5 wants to merge 1 commit into from
+7 −1
Closed

metrics: fall back to mockWriter on file open failure #608

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion internal/metrics/metrics.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ import (
"os"

"github.com/rs/zerolog"
"github.com/sirupsen/logrus"
)

type Writer interface {
Expand Down Expand Up @@ -57,7 +58,12 @@ func NewZerologMetrics(enabled bool, target string, containerID string) Writer {
zerolog.TimeFieldFormat = zerolog.TimeFormatUnixNano
file, err := os.OpenFile(target, os.O_CREATE|os.O_WRONLY|os.O_APPEND, 0666)
if err != nil {
return nil
// Fall back to a no-op writer instead of returning nil; the
// caller assigns this directly to a global used via
// metrics.Capture() in 19+ sites and a nil receiver would crash
// urunc on the next event. The user gets a warning instead.
logrus.Warnf("metrics: failed to open %s: %v; metrics disabled", target, err)
return &mockWriter{}
}
logger := zerolog.New(file).Level(zerolog.InfoLevel).With().Timestamp().Logger()
return &zerologMetrics{
Expand Down