metrics: fall back to mockWriter on file open failure#608
Closed
SAY-5 wants to merge 1 commit into
Closed
Conversation
Signed-off-by: SAY-5 <say.apm35@gmail.com>
✅ Deploy Preview for urunc canceled.
|
Contributor
|
This PR is duplicate with #596 and does not follow the contribution guide. Therefore, we will not review it. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #595.
NewZerologMetricsreturned nil when timestamps were enabled but the destination file couldn't be opened. The caller incmd/urunc/main.goassigns the result to a global used bymetrics.Capture()in 19+ sites; the next event then nil-derefs and crashes urunc silently — most often when a user enables[timestamps]in/etc/urunc/config.tomlbefore/var/log/urunc/exists. Return&mockWriter{}(the same fallback the disabled branch uses) and log a warning. Container creation now degrades to no-metrics instead of panicking.