Skip to content

feat: add highlight_type to files.completeUploadExternal and filesUploadV2 #1589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zimeg wants to merge 4 commits into
base: main
Choose a base branch
from
+15 −0
Open

feat: add highlight_type to files.completeUploadExternal and filesUploadV2 #1589

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
685d67f
feat: add highlight_type to files.completeUploadExternal and filesUpl…
zimeg May 15, 2026
02238e3
Merge branch 'main' into feat/highlight-type
zimeg May 15, 2026
6d557e3
docs: use consistent javadoc for highlightType fields
zimeg May 15, 2026
32490c0
refactor: remove redundant highlightType set on uploadFile in single-…
zimeg May 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions slack-api-client/src/main/java/com/slack/api/methods/impl/MethodsClientImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2520,6 +2520,7 @@ public FilesUploadV2Response filesUploadV2(FilesUploadV2Request req) throws IOEx
FilesCompleteUploadExternalRequest.FileDetails file = new FilesCompleteUploadExternalRequest.FileDetails();
file.setId(fileId);
file.setTitle(uploadFile.getTitle());
file.setHighlightType(uploadFile.getHighlightType());

files.add(file);
}
Expand Down Expand Up @@ -2548,6 +2549,7 @@ public FilesUploadV2Response filesUploadV2(FilesUploadV2Request req) throws IOEx
FilesCompleteUploadExternalRequest.FileDetails file = new FilesCompleteUploadExternalRequest.FileDetails();
file.setId(fileId);
file.setTitle(uploadFile.getTitle());
file.setHighlightType(req.getHighlightType());
files.add(file);
}
return helper.completeUploads(req, files);
Expand Down
4 changes: 4 additions & 0 deletions ...src/main/java/com/slack/api/methods/request/files/FilesCompleteUploadExternalRequest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,10 @@ public class FilesCompleteUploadExternalRequest implements SlackApiRequest {
public static class FileDetails {
private String id; // required
private String title; // optional
/**
* Optional highlight type hint for the file. The upload processing job may overwrite this value.
*/
private String highlightType;
}

}
9 changes: 9 additions & 0 deletions slack-api-client/src/main/java/com/slack/api/methods/request/files/FilesUploadV2Request.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,11 @@ public class FilesUploadV2Request implements SlackApiRequest {
* (this is mainly for backward compatibility - using uploadFiles instead is recommended)
*/
private String snippetType;
/**
* Optional highlight type hint for the file. The upload processing job may overwrite this value.
* (this is mainly for backward compatibility - using uploadFiles instead is recommended)
*/
private String highlightType;

/**
* Fetches all the file metadata for better v1 compatibility when this property is true.
Expand Down Expand Up @@ -113,6 +118,10 @@ public static class UploadFile {
* Syntax type of the snippet being uploaded.
*/
private String snippetType;
/**
* Optional highlight type hint for the file. The upload processing job may overwrite this value.
*/
private String highlightType;
}

/**
Expand Down