feat: add highlight_type to files.completeUploadExternal and filesUploadV2#1589
Open
zimeg wants to merge 4 commits into
Open
feat: add highlight_type to files.completeUploadExternal and filesUploadV2#1589zimeg wants to merge 4 commits into
zimeg wants to merge 4 commits into
Conversation
…oadV2 Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (30.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #1589 +/- ##
============================================
- Coverage 73.29% 73.26% -0.04%
+ Complexity 4519 4517 -2
============================================
Files 478 478
Lines 14298 14300 +2
Branches 1490 1490
============================================
- Hits 10480 10477 -3
- Misses 2930 2934 +4
- Partials 888 889 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
…file path highlight_type is only needed at the completion step, not during upload. Read directly from the request object instead of round-tripping through uploadFile. Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds
highlight_typesupport tofiles.completeUploadExternaland thefilesUploadV2method.The
highlight_typeparameter allows specifying the file type hint for uploads (e.g.png,jpg,gif), enabling optimistic rendering before the async upload processing job completes.📚 https://docs.slack.dev/reference/methods/files.completeUploadExternal
Changes
highlightTypetoFilesCompleteUploadExternalRequest.FileDetails(per-file in thefilesarray)highlightTypetoFilesUploadV2Request(top-level for single-file uploads) andFilesUploadV2Request.UploadFile(for multi-file uploads)MethodsClientImpl.filesUploadV2to passhighlightTypethrough to eachFileDetailsobject in the completion stepUsage
Related PRs
Category (place an
xin each of the[ ])Requirements
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.