Improve intersection of ConstantArray and AccessoryIsList#5067
Merged
ondrejmirtes merged 10 commits intophpstan:2.1.xfrom Mar 11, 2026
Merged
Improve intersection of ConstantArray and AccessoryIsList#5067ondrejmirtes merged 10 commits intophpstan:2.1.xfrom
ondrejmirtes merged 10 commits intophpstan:2.1.xfrom
Conversation
VincentLanglet
commented
Feb 27, 2026
VincentLanglet
force-pushed
the
experimental/array-list
branch
from
93ff38c to
65797b9
Compare
Collaborator
|
This pull request has been marked as ready for review. |
Contributor
Author
|
This solve phpstan/phpstan#11602 (comment) but not the whole issue. |
VincentLanglet
force-pushed
the
experimental/array-list
branch
from
4e14478 to
355d824
Compare
VincentLanglet
commented
Feb 27, 2026
staabm
approved these changes
Feb 28, 2026
Contributor
staabm
left a comment
staabm
left a comment
There was a problem hiding this comment.
I think this makes sense. Ondrej should have another look though.
Contributor
Author
I agree ; please take a look @ondrejmirtes |
Member
|
Thank you! This is how I'd approach it too 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proof of the gain in the next PR #5069