Fix list description with offset required#5212
Merged
VincentLanglet merged 1 commit intophpstan:2.1.xfrom Mar 12, 2026
Merged
Conversation
VincentLanglet
commented
Mar 12, 2026
| public function testList(array $b): void | ||
| { | ||
| if (array_key_exists(3, $b)) { | ||
| assertType('list{0: string, 1: string, 2?: string, 3: string}', $b); |
Contributor
Author
There was a problem hiding this comment.
Since 3 is required, 2 shouldn't be described as optional.
VincentLanglet
force-pushed
the
makeOffsetRequired
branch
2 times, most recently
from
3a3b2c9 to
f25ff73
Compare
VincentLanglet
force-pushed
the
makeOffsetRequired
branch
from
f25ff73 to
8fc4759
Compare
Collaborator
|
This pull request has been marked as ready for review. |
staabm
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now #5067 is merged, it allows this.