-
Notifications
You must be signed in to change notification settings - Fork 0
ci: forward bump input to reusable release workflow #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,12 +5,21 @@ on: | |
| tags: | ||
| - 'v*' | ||
| workflow_dispatch: | ||
| inputs: | ||
| bump: | ||
| description: 'Version bump type' | ||
| required: true | ||
| type: choice | ||
| options: | ||
| - patch | ||
| - minor | ||
| - major | ||
|
|
||
| jobs: | ||
| release: | ||
| uses: netresearch/skill-repo-skill/.github/workflows/release.yml@main | ||
| with: | ||
| bump: ${{ inputs.bump }} | ||
| permissions: | ||
| id-token: write | ||
| attestations: write | ||
| contents: write | ||
| pull-requests: write | ||
|
Comment on lines
23
to
25
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Marking
bumpasrequired: truechanges the manual-dispatch UX: triggeringworkflow_dispatchnow always requires selecting a bump value. If you want to preserve the previous ability to run a manual release without bumping (or to align with the tag-push behavior whereinputs.bumpis empty/skip), consider making it optional and setting a default (e.g.,default: patch) or leaving it non-required so callers can omit it.