ci: forward bump input to reusable release workflow#15
Conversation
…kflow The caller workflow defined workflow_dispatch without inputs, so 'gh workflow run release.yml --field bump=...' failed with 'Unexpected inputs provided: ["bump"]'. Declare the bump input on the caller and forward it via 'with:' to the reusable workflow. Tag push still works unchanged — inputs.bump is empty, which the reusable workflow's bump job treats as a no-op.
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds a bump input to the manually-dispatched release workflow and forwards it into the reusable release workflow to support gh workflow run ... --field bump=....
Changes:
- Declares
workflow_dispatch.inputs.bumpas a choice input (patch/minor/major). - Forwards
inputs.bumpto the reusable release workflow viajobs.release.with.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| permissions: | ||
| id-token: write | ||
| attestations: write | ||
| contents: write | ||
| pull-requests: write |
There was a problem hiding this comment.
This change also removes id-token: write and attestations: write from the job permissions (not mentioned in the PR description). If the reusable release workflow relies on OIDC (e.g., for signing/publishing) or artifact attestations, the release may fail at runtime. Consider restoring those permissions (or explicitly documenting why they’re no longer needed) to keep the change scoped to forwarding bump.
| required: true | ||
| type: choice | ||
| options: | ||
| - patch | ||
| - minor | ||
| - major |
There was a problem hiding this comment.
Marking bump as required: true changes the manual-dispatch UX: triggering workflow_dispatch now always requires selecting a bump value. If you want to preserve the previous ability to run a manual release without bumping (or to align with the tag-push behavior where inputs.bump is empty/skip), consider making it optional and setting a default (e.g., default: patch) or leaving it non-required so callers can omit it.
Declare the
bumpinput onworkflow_dispatchand forward it to the reusable release workflow viawith:.Without this,
gh workflow run release.yml --field bump=minorfails withUnexpected inputs provided: ["bump"], forcing manual tag+bump work outside the workflow.Tag-push releases are unaffected —
inputs.bumpis empty, which the reusable workflow's bump job treats as skip.