Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/streamable-http-restart-close.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@modelcontextprotocol/client': patch
---

Allow StreamableHTTPClientTransport to be restarted after close by clearing its aborted controller.
3 changes: 2 additions & 1 deletion packages/client/src/client/streamableHttp.ts
Original file line number Diff line number Diff line change
Expand Up @@ -345,7 +345,7 @@ export class StreamableHTTPClientTransport implements Transport {

const reconnect = (): void => {
this._cancelReconnection = undefined;
if (this._abortController?.signal.aborted) return;
if (!this._abortController || this._abortController.signal.aborted) return;
this._startOrAuthSse(options).catch(error => {
this.onerror?.(new Error(`Failed to reconnect SSE stream: ${error instanceof Error ? error.message : String(error)}`));
try {
Expand Down Expand Up @@ -513,6 +513,7 @@ export class StreamableHTTPClientTransport implements Transport {
} finally {
this._cancelReconnection = undefined;
this._abortController?.abort();
this._abortController = undefined;
this.onclose?.();
}
}
Expand Down
12 changes: 12 additions & 0 deletions packages/client/test/client/streamableHttp.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,18 @@ describe('StreamableHTTPClientTransport', () => {
await reconnectTransport.close().catch(() => {});
});

it('can be started again after close()', async () => {
await transport.start();
const firstAbortController = transport['_abortController'];

await transport.close();

expect(firstAbortController?.signal.aborted).toBe(true);
expect(transport['_abortController']).toBeUndefined();
await expect(transport.start()).resolves.toBeUndefined();
expect(transport['_abortController']).toBeDefined();
});

it('should terminate session with DELETE request', async () => {
// First, simulate getting a session ID
const message: JSONRPCMessage = {
Expand Down
Loading