Allow streamable HTTP transport restart after close#2174
Open
FU-max-boop wants to merge 1 commit into
Open
Conversation
🦋 Changeset detectedLatest commit: d2bf224 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@modelcontextprotocol/client
@modelcontextprotocol/codemod
@modelcontextprotocol/server
@modelcontextprotocol/express
@modelcontextprotocol/fastify
@modelcontextprotocol/hono
@modelcontextprotocol/node
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1641.
StreamableHTTPClientTransport.close()aborted the current controller but kept the aborted controller object around. A laterstart()therefore treated the transport as already started, which breaks reconnect flows that close the transport during OAuth and then start it again after authorization.This clears the controller after aborting it, and updates the delayed reconnect guard so late scheduler callbacks also stop when the transport has been closed and the controller has been cleared.
Tests
corepack pnpm --filter @modelcontextprotocol/client exec vitest run test/client/streamableHttp.test.tscorepack pnpm --filter @modelcontextprotocol/client lintcorepack pnpm --filter @modelcontextprotocol/client typecheckgit diff --checkNote: the first attempt to run the package test via
corepack pnpm --filter @modelcontextprotocol/client test -- streamableHttp.test.tsexecuted the broader client suite and only failed becausebarrelClean.test.tsspawnspnpmby name, while this environment only exposes pnpm through Corepack. The targetedpnpm exec vitestrun above passed.