Add LD-pruned biallelic SNP access method#1130
Open
adilraza99 wants to merge 12 commits intomalariagen:masterfrom
Open
Add LD-pruned biallelic SNP access method#1130adilraza99 wants to merge 12 commits intomalariagen:masterfrom
adilraza99 wants to merge 12 commits intomalariagen:masterfrom
Conversation
Contributor
Author
|
Hey Jon, Would you be okay with me adding one? |
Contributor
Author
|
@jonbrenas just checking back on this - would be great to hear your thoughts when you get a chance. Also linking Tristan’s earlier (#1049 (comment)) here for context. |
Contributor
Author
|
Hi @jonbrenas, could you please review this PR? I’ve also added a small example notebook demonstrating the LD-pruned SNP workflow. |
Add a minimal, runnable example demonstrating usage of biallelic_snp_calls_ld_pruned() with basic validation and downstream compatibility.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add support for generating LD-pruned SNP datasets from the existing biallelic SNP call pipeline.
Changes
AnophelesLdAnalysismixinbiallelic_snp_calls_ld_pruned()methodld_params.pyfor LD pruning parametersAnophelesDataResourceImplementation
The method builds on top of
biallelic_snp_calls():allel.locate_unlinked_dask_compress_datasetxarray.DatasetNotes
n_snpsparameterTests
Added tests to verify:
closes #1049