refactor: tighten type annotations for cache variables in snp_data.py#1129
Open
faizavk wants to merge 2 commits intomalariagen:masterfrom
Open
refactor: tighten type annotations for cache variables in snp_data.py#1129faizavk wants to merge 2 commits intomalariagen:masterfrom
faizavk wants to merge 2 commits intomalariagen:masterfrom
Conversation
faizavk
force-pushed
the
tighten-snp-types
branch
from
76ae17c to
995ddad
Compare
Collaborator
|
Hi @faizavk, could you move the type definitions to |
faizavk
force-pushed
the
tighten-snp-types
branch
from
995ddad to
204a409
Compare
Author
|
Hi @jonbrenas, thanks for the feedback! I've moved the type definitions to base_params.py as zarr_group and numpy_ndarray TypeAliases, and updated snp_data.py to reference them consistently. Please let me know if this looks correct. |
jonbrenas
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses a TODO in AnophelesSnpData.init by tightening the type hints for the internal cache variables. Loose Dict types and untyped None assignments have been replaced with strict Dict, Optional, zarr.hierarchy.Group, and np.ndarray definitions based on their respective loading methods.