Improve PLINK filename hashing with canonicalized parameters and SHA256#1122
Open
mithil27360 wants to merge 6 commits intomalariagen:masterfrom
Open
Improve PLINK filename hashing with canonicalized parameters and SHA256#1122mithil27360 wants to merge 6 commits intomalariagen:masterfrom
mithil27360 wants to merge 6 commits intomalariagen:masterfrom
Conversation
Fixes malariagen#1113 Introduce _compute_plink_selection_hash() helper to compute a deterministic hash from all content-affecting selection parameters: sample_sets, sample_query, sample_query_options, sample_indices, site_mask, and random_seed. Canonicalize list inputs such as sample_sets via sorting to avoid order-dependent hashes. Use truncated SHA256 for stable, collision- resistant identifiers. Append the hash to the existing filename prefix while preserving human readability. Example filename: 2L.1000.2.8.0.959c5581b5 Tests added to verify: - deterministic hashing (same params -> same hash) - different parameters produce different hashes - ordering of sample_sets does not affect the result - hash format and length
Author
|
Note: this implementation canonicalizes list parameters such as |
Author
|
Could a maintainer please approve the workflows to run CI? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1113
This PR ensures that PLINK export filenames uniquely represent the dataset
selection by hashing all content-affecting parameters.
Changes:
hash from selection parameters
sample_setsvia sorting to avoidorder-dependent hashes
Example filename:
2L.1000.2.8.0.959c5581b5Tests added to verify:
sample_setsdoes not affect the result