Skip to content

Introduce node-ip for prepare.sh script #772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
byteocean wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Introduce node-ip for prepare.sh script #772

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion hack/prepare.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ set -Eeuo pipefail
OPT_MULTIPORT=false
OPT_SYNC_BRIDGE=false
OPT_ALLOW_ULA=false
OPT_NODE_IP=""

BLUEFIELD_IDENTIFIERS=("MT_0000000543" "MT_0000000541")
MAX_NUMVFS_POSSIBLE=126
Expand Down Expand Up @@ -361,7 +362,11 @@ function make_config() {
conf_pf0="$(get_ifname 0)"
conf_pf1="$(get_ifname 1)"
conf_vf_pattern="$(get_pattern "${devs[0]}")"
conf_ipv6="$(get_ipv6)"
if [[ -n "$OPT_NODE_IP" ]]; then
conf_ipv6="$OPT_NODE_IP"
else
conf_ipv6="$(get_ipv6)"
fi
Copy link
Copy Markdown
Contributor

@PlagueCZ PlagueCZ Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good candidate for bash parameter expansion ${parameter:−word}

Untested, but this should be it:

conf_ipv6=${OPT_NODE_IP:-$(get_ipv6)}


{ echo "# This has been generated by prepare.sh"
echo "no-stats"
Expand Down Expand Up @@ -438,6 +443,10 @@ while [[ $# -gt 0 ]]; do
--allow-ula)
OPT_ALLOW_ULA=true
;;
--node-ip)
shift
Copy link
Copy Markdown
Contributor

@PlagueCZ PlagueCZ Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a bash getopt expert, but why is there only this shift and not for all of the arguments?

OPT_NODE_IP="$1"
;;
*)
err "Invalid argument $1"
esac
Expand Down
Loading