Open
Conversation
PlagueCZ
requested changes
Apr 13, 2026
| OPT_ALLOW_ULA=true | ||
| ;; | ||
| --node-ip) | ||
| shift |
Contributor
There was a problem hiding this comment.
Not a bash getopt expert, but why is there only this shift and not for all of the arguments?
| conf_ipv6="$OPT_NODE_IP" | ||
| else | ||
| conf_ipv6="$(get_ipv6)" | ||
| fi |
Contributor
There was a problem hiding this comment.
This is a good candidate for bash parameter expansion ${parameter:−word}
Untested, but this should be it:
conf_ipv6=${OPT_NODE_IP:-$(get_ipv6)}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add one extra starting flag to specify the node IP used to parse for the underlaying address prefix.
background: In some cases, loopback interface has two IPv6 addresses. The current prepare script always takes the first one for parsing. It helps in deployment to overwrite this behaviour by specifying the node IPv6 address.