Skip to content

Fix NSRangeException crash in TextInput delegate adapters #55950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lukeharvey wants to merge 1 commit into from
Closed

Fix NSRangeException crash in TextInput delegate adapters #55950

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions packages/react-native/Libraries/Text/TextInput/RCTBackedTextInputDelegateAdapter.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,15 @@ - (BOOL)textField:(__unused UITextField *)textField
return YES;
}

// Clamp the range to the current text length to avoid NSRangeException.
NSUInteger textLength = _backedTextInputView.attributedText.length;
if (range.location > textLength) {
return NO;
}
if (range.location + range.length > textLength) {
range = NSMakeRange(range.location, textLength - range.location);
}

NSMutableAttributedString *attributedString = [_backedTextInputView.attributedText mutableCopy];
[attributedString replaceCharactersInRange:range withString:newText];
[_backedTextInputView setAttributedText:[attributedString copy]];
Expand Down Expand Up @@ -292,8 +301,13 @@ - (BOOL)textView:(__unused UITextView *)textView shouldChangeTextInRange:(NSRang
return NO;
}

if (range.location + range.length > _backedTextInputView.text.length) {
range = NSMakeRange(range.location, _backedTextInputView.text.length - range.location);
// Clamp the range to the current text length to avoid NSRangeException.
NSUInteger textLength = _backedTextInputView.attributedText.length;
if (range.location > textLength) {
return NO;
}
if (range.location + range.length > textLength) {
range = NSMakeRange(range.location, textLength - range.location);
} else if ([newText isEqualToString:text]) {
_textDidChangeIsComing = YES;
return YES;
Expand Down
Loading