Skip to content

Support the deprecated Azure DevOps oauth apps#985

Open
vinokurig wants to merge 1 commit intomainfrom
che-23785
Open

Support the deprecated Azure DevOps oauth apps#985
vinokurig wants to merge 1 commit intomainfrom
che-23785

Conversation

@vinokurig
Copy link
Copy Markdown
Contributor

What does this PR do?

Support the deprecated Azure DevOps oauth apps, see https://learn.microsoft.com/en-us/azure/devops/integrate/get-started/authentication/oauth?view=azure-devops#azure-devops-oauth-deprecated

Screenshot/screencast of this PR

What issues does this PR fix or reference?

fixes eclipse-che/che#23785

How to test this PR?

  1. Deploy che with the pull request image: quay.io/eclipse/che-server:pr-
  2. Apply Azure Devops oauth secret e.g.
kind: Secret
apiVersion: v1
metadata:
  name: azure-devops-oauth-config
  namespace: eclipse-che
  labels:
    app.kubernetes.io/component: oauth-scm-configuration
    app.kubernetes.io/part-of: che.eclipse.org
  annotations:
    che.eclipse.org/oauth-scm-server: azure-devops
stringData:
  id: id
  secret: secrete
type: Opaque
  1. See: the che-server pod reconciles without any errors.

PR Checklist

As the author of this Pull Request I made sure that:

Release Notes

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@github-actions
Copy link
Copy Markdown

Docker image build succeeded: quay.io/eclipse/che-server:pr-985

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/cheServer/deployment", "value": {containers: [{image: "quay.io/eclipse/che-server:pr-985", name: che}]}}]"

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Mar 27, 2026

@vinokurig: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v19-azure-no-pat-oauth-flow-raw-devfile-url 9c00b99 link true /test v19-azure-no-pat-oauth-flow-raw-devfile-url

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Mar 27, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tolusha, vinokurig

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Che server pod fails to start if the Azure oauth config does not contain tenant id data

2 participants