Conversation
vinokurig
requested review from
a team,
deerskindoll,
gtrivedi88 and
mkuznyetsov
as code owners
|
🎊 Navigate the preview: https://69c6787560b9712e3a95acab--eclipse-che-docs-pr.netlify.app 🎊 |
|
Click here to review and test in web IDE: |
-525C86?logo=eclipse-che&labelColor=red){kind=icon}
vinokurig
force-pushed
the
che-23505
branch
3 times, most recently
from
316442c to
06207b2
Compare
svor
left a comment
svor
left a comment
There was a problem hiding this comment.
@vinokurig Since we have eclipse-che/che#23785, I think we shouldn't remove information about OAuth 2.0 deprecation. WDYT?
|
@gtrivedi88 could you please take a look? |
I don't think we need this notification after we remove instructions about the deprecated Azure DevOps oauth application. If customer still uses the old application they would not need the instructions, it will still work with the eclipse-che/che-server#985 pull request. |
There was a problem hiding this comment.
looks good, some suggestions
@svor Will we be backporting this to 3.27?
...nistration-guide/partials/proc_setting-up-the-microsoft-azure-devops-services-oauth-app.adoc
Outdated
Show resolved
Hide resolved
...nistration-guide/partials/proc_setting-up-the-microsoft-azure-devops-services-oauth-app.adoc
Outdated
Show resolved
Hide resolved
...ation-guide/partials/proc_applying-the-microsoft-azure-devops-services-oauth-app-secret.adoc
Outdated
Show resolved
Hide resolved
...ation-guide/partials/proc_applying-the-microsoft-azure-devops-services-oauth-app-secret.adoc
Outdated
Show resolved
Hide resolved
| OAuth 2.0 isn't supported on Azure DevOps Server, see link:https://learn.microsoft.com/en-us/azure/devops/integrate/get-started/authentication/oauth?view=azure-devops[the documentation page]. | ||
| [IMPORTANT] | ||
| Azure DevOps OAuth 2.0 is deprecated and no longer accepts new registrations, with full deprecation planned for 2026. See link:https://learn.microsoft.com/en-us/azure/devops/integrate/get-started/authentication/oauth?view=azure-devops[the documentation page]. | ||
| . Set up an application in Microsoft Entra ID. |
There was a problem hiding this comment.
The assembly title (line 8), :description: (line 2), :navtitle: (line 4), and [id=...] (line 7) still reference "Microsoft Azure DevOps Services" but the procedures now use Microsoft Entra ID. Update these to align with the new flow.
Also: the two removed [IMPORTANT] blocks mentioned OAuth 2.0 deprecation and Azure DevOps Server limitations. Should the assembly introduction note that Microsoft Entra ID replaces the deprecated OAuth 2.0 app registration?
|
@gtrivedi88 thanks for the review. It's for 3.28 |
…osoft-azure-devops-services-oauth-app.adoc Co-authored-by: Gaurav Trivedi <90042568+gtrivedi88@users.noreply.github.com>
…osoft-azure-devops-services-oauth-app.adoc Co-authored-by: Gaurav Trivedi <90042568+gtrivedi88@users.noreply.github.com>
…oft-azure-devops-services-oauth-app-secret.adoc Co-authored-by: Gaurav Trivedi <90042568+gtrivedi88@users.noreply.github.com>
…oft-azure-devops-services-oauth-app-secret.adoc Co-authored-by: Gaurav Trivedi <90042568+gtrivedi88@users.noreply.github.com>
3 participants
What does this pull request change?
Update Azure DevOps Oauth configuration instructions
What issues does this pull request fix or reference?
eclipse-che/che#23505
Specify the version of the product this pull request applies to
next
Pull Request checklist
The author and the reviewers validate the content of this pull request with the following checklist, in addition to the automated tests.
Validate language on files added or modifiedstep reports no vale warnings.