Skip to content

feat(flexible-outcalls): add metric for candid encoding/decoding failures#9643

Open
fspreiss wants to merge 1 commit intomasterfrom
fspreiss/IC-1952-candid-error-metrics
Open

feat(flexible-outcalls): add metric for candid encoding/decoding failures#9643
fspreiss wants to merge 1 commit intomasterfrom
fspreiss/IC-1952-candid-error-metrics

Conversation

@fspreiss
Copy link
Copy Markdown
Contributor

  • Adds a flexible_ok_responses_candid_failures stat to CanisterHttpBatchStats that tracks when flexible_ok_responses_into_consensus_response silently drops a response group due to a
    candid decode/encode failure.
  • Exposes it as the canister_http_flexible_candid_failures Prometheus counter in FinalizerMetrics, alongside the existing canister HTTP delivery metrics.
  • Rework the iterator chain from filter_map/inspect to map/inspect/flatten so both successful conversions and failures are observable before filtering.

@github-actions github-actions bot added the feat label Mar 28, 2026
Base automatically changed from fspreiss/CRP-1952-deliver-responses-to-execution to master March 28, 2026 20:51
@fspreiss fspreiss force-pushed the fspreiss/IC-1952-candid-error-metrics branch from 06d0ebc to f0b8305 Compare March 28, 2026 21:41
@fspreiss fspreiss marked this pull request as ready for review March 28, 2026 22:44
@fspreiss fspreiss requested a review from a team as a code owner March 28, 2026 22:44
@fspreiss fspreiss requested a review from eichhorl March 28, 2026 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant