Conversation
fspreiss
changed the title
eichhorl
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the
IntoMessagespath for flexible HTTP outcall ok-responses, converting eachFlexibleCanisterHttpResponsesgroup from the consensus payload into a single Candid-encodedConsensusResponsefor delivery to the execution environment.For each flexible response group, the individual
CanisterHttpResponsePayloads(already Candid-encoded by the HTTP adapter) are decoded, collected into aVec, wrapped inFlexibleHttpRequestResult::Ok(vec![...]), and re-encoded as a singlePayload::Datafor the canister callback.Reject entries (infrastructure-level failures like DNS/network errors) are filtered out as this path is unrechable due to payload building/validation ensuring that no reject responses are included in the ok-payload (see #9572).
If Candid decoding or encoding fails, the delivery of the response is skipped and a timeout will eventually gracefully end the outstanding callback.