Skip to content

change #include <unzip.h> to #include <minizip/unzip.h>#274

Open
Architector4 wants to merge 2 commits intocortex-command-community:developmentfrom
Architector4:patch-minizip-import
Open

change #include <unzip.h> to #include <minizip/unzip.h>#274
Architector4 wants to merge 2 commits intocortex-command-community:developmentfrom
Architector4:patch-minizip-import

Conversation

@Architector4
Copy link
Contributor

This lets the codebase built on my Arch Linux system again. HeliumAnt said it should be fine to do this lmao

@Architector4
Copy link
Contributor Author

msbuild go shit yourself

i had a rough day ok

This should have been causing issues for a while, unknown why it hasn't
yet. The changes to minizip pkg-config that make this necessary are already 2y old and are already
part of the previous release tag.
Copy link
Contributor

@HeliumAnt HeliumAnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lol, the only reason this wasn't already an issue 2y ago, is that arch skipped the 1.3.1.2 tag on zlib and minizip.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants