Skip to content

Fix renovate for OTel dependencies #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anuraaga merged 2 commits into from
Mar 16, 2026
Merged

Fix renovate for OTel dependencies #169

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7e9e742
Fix renovate for OTel dependencies
anuraaga Mar 16, 2026
589e8c6
Lock
anuraaga Mar 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion connectrpc-otel/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,10 @@ classifiers = [
]
dependencies = [
"opentelemetry-api>=1.39.1",
"opentelemetry-instrumentation==0.60b1",
# We do not want to prevent users from updating OTel when connectrpc isn't depending on
# the latest. This does introduce a possibility of incompatibilities, but there is no
# alternative, and in practice, the APIs we use have been stable for a long time.
"opentelemetry-instrumentation>=0.60b1",
Copy link
Member

@stefanvanburen stefanvanburen Mar 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going to say we ought to loosen this to a non "beta" release, but I guess they're marking all of the 0.x releases that way 😄

Copy link
Collaborator Author

@anuraaga anuraaga Mar 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to OTel :)

]

[dependency-groups]
Expand Down
9 changes: 6 additions & 3 deletions renovate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"packageRules": [
{
"matchManagers": ["github-actions"],
"matchUpdateTypes": ["*"],
"separateMajorMinor": false,
"groupName": "GitHub Actions"
},
{
Expand All @@ -17,14 +17,17 @@
"project.dependencies",
"project.optional-dependencies"
],
"matchFileNames": ["pyproject.toml"],
"matchFileNames": ["**/pyproject.toml"],
// We manage production dependencies ourselves, only bumping
// when necessary.
"enabled": false
},
{
"matchCategories": ["python"],
"matchUpdateTypes": ["*"],
"separateMajorMinor": false,
// Needed to bump dev OTel dependencies. If a blanket value here doesn't make sense
// in the future, we can separate out packageRules / group name for OTel.
"ignoreUnstable": false,
"groupName": "Python dependencies"
},
{
Expand Down
2 changes: 1 addition & 1 deletion uv.lock
View file
Open in desktop
Copy link
Member

@stefanvanburen stefanvanburen Mar 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kinda strange to me that this adjusts the uv.lock at the root; is that normal with workspaces or will we eventually have a separate uv.lock for connectrpc-otel?

Copy link
Collaborator Author

@anuraaga anuraaga Mar 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I think it's normal for workspaces, also languages like Node behave the same. The lock is only for repo development, not package installation, so the idea is to make sure any repo developer has the same experience. While multiple lock files can also achieve that, a single lock file can as well - unless we run into any had conflicts but for dev dependencies that tends to be rare.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading