Skip to content

Fix renovate for OTel dependencies#169

Merged
anuraaga merged 2 commits intoconnectrpc:mainfrom
anuraaga:renovate-otel
Mar 16, 2026
Merged

Fix renovate for OTel dependencies#169
anuraaga merged 2 commits intoconnectrpc:mainfrom
anuraaga:renovate-otel

Conversation

@anuraaga
Copy link
Collaborator

@anuraaga anuraaga commented Mar 16, 2026

Sorry my previous attempt was a complete misread of the huge configuration options reference for Renovate. Instead of matchUpdateTypes, it's separateMajorMinor that allows major/minor to be in a single PR. And then there was also a ignoreUnstable flag to bump the b* dependencies.

While my intent was for lock file maintenance to be grouped in too, renovate doesn't support that. It was a nice-to-have anyways (main motivation is possibility of lockfile conflicts between PRs, though they're rare)

Less related but the pin in dependencies, while intuitive at first since it's a beta dependency, would also cause stuck users as well as stuck renovate, I have loosened it with the comment on why we have to.

And while it seemed to be hitting the subprojects anyways (maybe it resolves the uv workspace implicitly), I went with the renovate docs that suggest a glob for matchFileNames.

Checked on my fork (with scheduleMondays removed from it) anuraaga#19

Signed-off-by: Anuraag Agrawal <anuraaga@gmail.com>
@anuraaga anuraaga requested a review from a team March 16, 2026 04:54
Signed-off-by: Anuraag Agrawal <anuraaga@gmail.com>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kinda strange to me that this adjusts the uv.lock at the root; is that normal with workspaces or will we eventually have a separate uv.lock for connectrpc-otel?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I think it's normal for workspaces, also languages like Node behave the same. The lock is only for repo development, not package installation, so the idea is to make sure any repo developer has the same experience. While multiple lock files can also achieve that, a single lock file can as well - unless we run into any had conflicts but for dev dependencies that tends to be rare.

# We do not want to prevent users from updating OTel when connectrpc isn't depending on
# the latest. This does introduce a possibility of incompatibilities, but there is no
# alternative, and in practice, the APIs we use have been stable for a long time.
"opentelemetry-instrumentation>=0.60b1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going to say we ought to loosen this to a non "beta" release, but I guess they're marking all of the 0.x releases that way 😄

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to OTel :)

@anuraaga anuraaga merged commit 6a123b7 into connectrpc:main Mar 16, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants