-
Notifications
You must be signed in to change notification settings - Fork 12
Sydshields/dash 1732 turn existing templates in js files #91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
syd-shields
merged 4 commits into
test-production
from
sydshields/dash-1732-turn-existing-templates-in-js-files
May 11, 2026
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
0070df7
remove built js files
syd-shields 009a835
add pkg.type = module to adaptPackageJsonForJavaScript so it's uncond…
syd-shields a240b02
consolidate workflows to one plauground.yml file to remove need to ma…
syd-shields a143d03
write contents to test-production and production branches
syd-shields File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,58 @@ | ||
| # Reusable workflow: validates TypeScript → JavaScript builds for playground- | ||
| # runnable templates and optionally commits the generated javascript/ tree. | ||
| # | ||
| # Called by playground-production.yml and playground-test-production.yml so that | ||
| # CI steps are defined in exactly one place. | ||
|
|
||
| name: Playground templates | ||
|
|
||
| on: | ||
| workflow_call: | ||
| inputs: | ||
| branch: | ||
| description: Target branch name (used only in log messages) | ||
| required: true | ||
| type: string | ||
|
|
||
| permissions: | ||
| contents: write | ||
|
|
||
| jobs: | ||
| playground-templates: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Clean javascript output directory | ||
| run: rm -rf javascript && mkdir -p javascript | ||
|
|
||
| - name: Setup pnpm | ||
| uses: pnpm/action-setup@v4 | ||
|
|
||
| - name: Setup Node.js | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: 20 | ||
| cache: pnpm | ||
|
|
||
| - name: Install dependencies | ||
| run: pnpm install --frozen-lockfile | ||
|
|
||
| - name: Build and validate playground TypeScript templates | ||
| env: | ||
| TEMPLATES_API_URL: ${{ vars.TEMPLATES_API_URL }} | ||
| run: pnpm run ci:playground | ||
|
|
||
| - name: Commit and push playground javascript (push only) | ||
| if: github.event_name == 'push' | ||
| run: | | ||
| git config user.name "github-actions[bot]" | ||
| git config user.email "41898282+github-actions[bot]@users.noreply.github.com" | ||
| git add -A javascript/ | ||
| if git diff --staged --quiet; then | ||
| echo "No javascript changes to commit." | ||
| else | ||
| git commit -m "chore: regenerate playground javascript templates" | ||
| git push | ||
| fi | ||
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Required workflow input
branchis never usedLow Severity
The
branchinput is declared asrequired: trueand its description claims it is "used only in log messages," butinputs.branchis never referenced anywhere in the workflow steps. Both caller workflows (playground-production.ymlandplayground-test-production.yml) are required to pass this parameter for no effect. This is dead code with a misleading description.Reviewed by Cursor Bugbot for commit a143d03. Configure here.