Skip to content

Sydshields/dash 1732 turn existing templates in js files#91

Merged
syd-shields merged 4 commits into
test-productionfrom
sydshields/dash-1732-turn-existing-templates-in-js-files
May 11, 2026
Merged

Sydshields/dash 1732 turn existing templates in js files#91
syd-shields merged 4 commits into
test-productionfrom
sydshields/dash-1732-turn-existing-templates-in-js-files

Conversation

@syd-shields
Copy link
Copy Markdown

@syd-shields syd-shields commented May 11, 2026

  • Turns on write permissions in workflow so that when CI runs, /javascript directory populates with playground compatible templates.
  • removes current placeholder /javascript folder

Note

Cursor Bugbot is generating a summary for commit a143d03. Configure here.

@syd-shields syd-shields requested a review from a team as a code owner May 11, 2026 13:57
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit a143d03. Configure here.

branch:
description: Target branch name (used only in log messages)
required: true
type: string
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Required workflow input branch is never used

Low Severity

The branch input is declared as required: true and its description claims it is "used only in log messages," but inputs.branch is never referenced anywhere in the workflow steps. Both caller workflows (playground-production.yml and playground-test-production.yml) are required to pass this parameter for no effect. This is dead code with a misleading description.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit a143d03. Configure here.

@syd-shields syd-shields merged commit 328dc16 into test-production May 11, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant