Skip to content

test: select the active FileSource actor in dispatcher checks #3002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
He-Pin wants to merge 1 commit into
base: main
Choose a base branch
from
+32 −12
Open

test: select the active FileSource actor in dispatcher checks #3002

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 32 additions & 12 deletions stream-tests/src/test/scala/org/apache/pekko/stream/io/FileSourceSpec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ import scala.concurrent.duration._
import com.google.common.jimfs.{ Configuration, Jimfs }

import org.apache.pekko
import pekko.actor.ActorRef
import pekko.stream._
import pekko.stream.IOResult._
import pekko.stream.impl.{ PhasedFusingActorMaterializer, StreamSupervisor }
Expand Down Expand Up @@ -81,6 +82,23 @@ class FileSourceSpec extends StreamSpec(UnboundedMailboxConfig) {
f
}

def fileSourceChildren(): Set[ActorRef] = {
SystemMaterializer(system).materializer
.asInstanceOf[PhasedFusingActorMaterializer]
.supervisor
.tell(StreamSupervisor.GetChildren, testActor)
expectMsgType[Children].children.filter(_.path.toString contains "fileSource").toSet
}

def expectNewFileSource(before: Set[ActorRef]): ActorRef =
awaitAssert {
val newChildren = fileSourceChildren().diff(before)
withClue(newChildren) {
newChildren.size shouldBe 1
newChildren.head
}
}

"FileSource" must {
"read contents from a file" in {
val chunkSize = 512
Expand Down Expand Up @@ -258,30 +276,32 @@ class FileSourceSpec extends StreamSpec(UnboundedMailboxConfig) {
}

"use dedicated blocking-io-dispatcher by default" in {
val before = fileSourceChildren()
val p = FileIO.fromPath(manyLines).runWith(TestSink())
val ref = expectNewFileSource(before)

SystemMaterializer(system).materializer
.asInstanceOf[PhasedFusingActorMaterializer]
.supervisor
.tell(StreamSupervisor.GetChildren, testActor)
val ref = expectMsgType[Children].children.find(_.path.toString contains "fileSource").get
try assertDispatcher(ref, ActorAttributes.IODispatcher.dispatcher)
finally p.cancel()
finally {
watch(ref)
p.cancel()
expectTerminated(ref)
}
}

"allow overriding the dispatcher using Attributes" in {
val before = fileSourceChildren()
val p = FileIO
.fromPath(manyLines)
.addAttributes(ActorAttributes.dispatcher("pekko.actor.default-dispatcher"))
.runWith(TestSink())
val ref = expectNewFileSource(before)

SystemMaterializer(system).materializer
.asInstanceOf[PhasedFusingActorMaterializer]
.supervisor
.tell(StreamSupervisor.GetChildren, testActor)
val ref = expectMsgType[Children].children.find(_.path.toString contains "fileSource").get
try assertDispatcher(ref, "pekko.actor.default-dispatcher")
finally p.cancel()
finally {
watch(ref)
p.cancel()
expectTerminated(ref)
}
}

"not signal onComplete more than once" in {
Expand Down