test: select the active FileSource actor in dispatcher checks#3002
Open
He-Pin wants to merge 1 commit into
Open
test: select the active FileSource actor in dispatcher checks#3002He-Pin wants to merge 1 commit into
He-Pin wants to merge 1 commit into
Conversation
Motivation: FileSourceSpec dispatcher checks can select a stale fileSource child left briefly by a previous materialization, which makes the dispatcher override assertion flaky. Modification: Capture existing fileSource children before starting each dispatcher-check stream, wait for exactly the newly materialized child, and watch it terminate after cancellation. Result: The checks assert the dispatcher of the stream started by the current test instead of a leftover child from an earlier materialization. Tests: - JDK 17 Scala 3.3.6: stream-tests / Test / testOnly org.apache.pekko.stream.io.FileSourceSpec - scalafmt --mode diff-ref=origin/main --quiet - scalafmt --list --mode diff-ref=origin/main - git diff --check References: Refs apache#2994
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
FileSourceSpec dispatcher checks can select a stale fileSource child left briefly by a previous materialization, which makes the dispatcher override assertion flaky.
Modification
Capture existing fileSource children before starting each dispatcher-check stream, wait for exactly the newly materialized child, and watch it terminate after cancellation.
Result
The checks assert the dispatcher of the stream started by the current test instead of a leftover child from an earlier materialization.
Tests
References
Refs #2994