Skip to content

IGNITE-28255 Fix java.io.NotSerializableException: org.apache.ignite.… #12901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
abashev wants to merge 2 commits into
base: master
Choose a base branch
from
Open

IGNITE-28255 Fix java.io.NotSerializableException: org.apache.ignite.… #12901

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
950fc89
IGNITE-28255 Fix java.io.NotSerializableException: org.apache.ignite.…
abashev Mar 17, 2026
77019c3
Merge branch 'master' into feature/IGNITE-28255
abashev Mar 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion ...src/main/java/org/apache/ignite/internal/processors/marshaller/MarshallerMappingItem.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@

package org.apache.ignite.internal.processors.marshaller;

import java.io.Serializable;
import java.util.Objects;
import org.apache.ignite.internal.Order;
import org.apache.ignite.plugin.extensions.communication.Message;
Expand All @@ -26,7 +27,10 @@
* Used to exchange mapping information on new mapping added or missing mapping requested flows.
* See {@link GridMarshallerMappingProcessor} javadoc for more information.
*/
public final class MarshallerMappingItem implements Message {
public final class MarshallerMappingItem implements Message, Serializable {
Copy link
Contributor

@anton-vinogradov anton-vinogradov Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The goal is to get rid of serialisable, not to add

Copy link
Contributor

@NSAmelchev NSAmelchev Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, but now many places require Serializable, for example TcpDiscoveryNodeAddedMessage#msgs, TcpDiscoveryClientReconnectMessage#msgs. In these and some other java SerDer (called via U.marshal(jdkMarshaller)) requires Serializable.

I suggest removing Serializable when it becomes possible.

Copy link
Contributor

@Vladsz83 Vladsz83 Mar 17, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anton-vinogradov , @NSAmelchev pls. note #12890 . Useful message. Should be removed in future but currently helps in development a lot.

/** */
private static final long serialVersionUID = 0L;

/** */
@Order(0)
byte platformId;
Expand Down
Loading