IGNITE-28255 Fix java.io.NotSerializableException: org.apache.ignite.…#12901
IGNITE-28255 Fix java.io.NotSerializableException: org.apache.ignite.…#12901abashev wants to merge 1 commit intoapache:masterfrom
Conversation
Possible compatibility issues. Please, check rolling upgrade casesThis PR modifies protected classes (with Order annotation). Affected files:
|
…internal.processors.marshaller.MarshallerMappingItem
abashev
force-pushed
the
feature/IGNITE-28255
branch
from
94e744c to
950fc89
Compare
| * See {@link GridMarshallerMappingProcessor} javadoc for more information. | ||
| */ | ||
| public final class MarshallerMappingItem implements Message { | ||
| public final class MarshallerMappingItem implements Message, Serializable { |
There was a problem hiding this comment.
The goal is to get rid of serialisable, not to add
There was a problem hiding this comment.
Correct, but now many places require Serializable, for example TcpDiscoveryNodeAddedMessage#msgs, TcpDiscoveryClientReconnectMessage#msgs. In these and some other java SerDer (called via U.marshal(jdkMarshaller)) requires Serializable.
I suggest removing Serializable when it becomes possible.
There was a problem hiding this comment.
@anton-vinogradov , @NSAmelchev pls. note #12890 . Useful message. Should be removed in future but currently helps in development a lot.
|
4 participants
…internal.processors.marshaller.MarshallerMappingItem
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
The Contribution Checklist
The description explains WHAT and WHY was made instead of HOW.
The following pattern must be used:
IGNITE-XXXX Change summarywhereXXXX- number of JIRA issue.(see the Maintainers list)
the
green visaattached to the JIRA ticket (see tabPR Checkat TC.Bot - Instance 1 or TC.Bot - Instance 2)Notes
If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com #ignite channel.