fix: validate plot_congestion.py CLI arguments#4074
Open
mithlohar144 wants to merge 2 commits intoThe-OpenROAD-Project:masterfrom
Open
fix: validate plot_congestion.py CLI arguments#4074mithlohar144 wants to merge 2 commits intoThe-OpenROAD-Project:masterfrom
mithlohar144 wants to merge 2 commits intoThe-OpenROAD-Project:masterfrom
Conversation
mithlohar144
force-pushed
the
fix/plot-congestion-arg-validation
branch
from
621cd56 to
0a28d28
Compare
Signed-off-by: Mithilesh Lohar <128236295+mithlohar144@users.noreply.github.com>
Member
|
Needs to be formatted with |
Collaborator
Not by me. |
Member
Collaborator
mithlohar144
force-pushed
the
fix/plot-congestion-arg-validation
branch
from
1267eaa to
e607af3
Compare
Signed-off-by: Mithilesh Lohar <128236295+mithlohar144@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a small CLI robustness issue in plot_congestion.py.
Problem:
The script accessed positional arguments directly and crashed with IndexError when invoked with too few arguments.
The script also accepted malformed trailing args (odd count) that should be rejected.