table: refine JTable overlong cell ellipsis positioning#76
Open
mbtaylor wants to merge 1 commit intoStarlink:masterfrom
Open
table: refine JTable overlong cell ellipsis positioning#76mbtaylor wants to merge 1 commit intoStarlink:masterfrom
mbtaylor wants to merge 1 commit intoStarlink:masterfrom
Conversation
Modify the recent change that elides overlong strings displayed in JTable cells in the middle; the ellipsis may now be placed either in the middle or at the end, depending on content. Roughly, strings with embedded whitespace (which are likely to be natural language text or similar) are elided at the end, but long strings without embedded whitespace (which are more likely to be something hierarchical like a filename or URL) are elided in the middle.
Member
Author
|
@fjebaker although the recent PR #75 works nicely for URLs and filenames I found myself getting annoyed by it with content like textual descriptions, where the interesting stuff is more likely at the start than the end of the string. So I put a heuristic in that tries to account for that. Whaddayathink? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modify the recent change that elides overlong strings displayed in JTable cells in the middle; the ellipsis may now be placed either in the middle or at the end, depending on content.
Roughly, strings with embedded whitespace (which are likely to be natural language text or similar) are elided at the end, but long strings without embedded whitespace (which are more likely to be something hierarchical like a filename or URL) are elided in the middle.