Clean up module outputFile calculation and move it to the specifications#6967
Open
alfonso-noriega wants to merge 1 commit intomainfrom
Open
Conversation
This was referenced Mar 10, 2026
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
5 tasks
Contributor
|
We detected some changes at Caution DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release. |
|
🤖 Code Review · #projects-dev-ai for questions ✅ Complete - No issues 📋 History✅ No issues → ✅ 2 findings → ❌ Failed → ✅ No issues |
59f0139 to
7b9999e
Compare
bbc0817 to
7b68eb7
Compare
Contributor
Coverage report
Test suite run success3811 tests passing in 1473 suites. Report generated by 🧪jest coverage report action from 40c8534 |
7b68eb7 to
c3ee349
Compare
packages/app/src/cli/models/extensions/specifications/checkout_ui_extension.ts
Outdated
Show resolved
Hide resolved
packages/app/src/cli/models/extensions/specifications/function.ts
Outdated
Show resolved
Hide resolved
24fb214 to
ecf7d0f
Compare
ryancbahan
reviewed
Mar 10, 2026
9bebf7c to
dd63de8
Compare
7e38d07 to
880b269
Compare
5647756 to
dcffdf5
Compare
This was referenced Mar 16, 2026
isaacroldan
reviewed
Mar 16, 2026
dcffdf5 to
b7dd050
Compare
5 tasks
b7dd050 to
a8cf663
Compare
a8cf663 to
40c8534
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

WHY are these changes introduced?
The
outputFileNameproperty was previously calculated dynamically using a getter method that relied on the extension's build configuration mode. This approach was inflexible and didn't allow for extension-specific customization of output file names.WHAT is this pull request doing?
outputFileNamefrom a computed getter to a direct property onExtensionInstancegetOutputFileNamemethod to theExtensionSpecificationinterfacegetOutputFileNamein all UI extension specifications to return${extension.handle}.jsgetOutputFileNamein function extensions to returnindex.wasmBuildConfigtype to use a discriminated union for better type safetyoutputFileNamein the constructor using the specification's method or defaults to empty stringHow to test your changes?
Measuring impact
How do we know this change was effective? Please choose one:
Checklist