Add manifest generation to include_assets build step#7016
Add manifest generation to include_assets build step#7016alfonso-noriega wants to merge 2 commits into02-wire-build-config-into-extension-specsfrom
Conversation
|
We detected some changes at Caution DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release. |
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/node/themes/api.d.ts@@ -5,7 +5,6 @@ export type ThemeParams = Partial<Pick<Theme, 'name' | 'role' | 'processing' | '
export type AssetParams = Pick<ThemeAsset, 'key'> & Partial<Pick<ThemeAsset, 'value' | 'attachment'>>;
export declare function fetchTheme(id: number, session: AdminSession): Promise<Theme | undefined>;
export declare function fetchThemes(session: AdminSession): Promise<Theme[]>;
-export declare function findDevelopmentThemeByName(name: string, session: AdminSession): Promise<Theme | undefined>;
export declare function themeCreate(params: ThemeParams, session: AdminSession): Promise<Theme | undefined>;
export declare function fetchThemeAssets(id: number, filenames: Key[], session: AdminSession): Promise<ThemeAsset[]>;
export declare function deleteThemeAssets(id: number, filenames: Key[], session: AdminSession): Promise<Result[]>;
packages/cli-kit/dist/public/node/themes/theme-manager.d.ts@@ -8,8 +8,8 @@ export declare abstract class ThemeManager {
protected abstract removeTheme(): void;
protected abstract context: string;
constructor(adminSession: AdminSession);
- findOrCreate(name?: string, role?: Role): Promise<Theme>;
- fetch(name?: string, role?: Role): Promise<Theme | undefined>;
+ findOrCreate(): Promise<Theme>;
+ fetch(): Promise<Theme | undefined>;
generateThemeName(context: string): string;
create(themeRole?: Role, themeName?: string): Promise<Theme>;
}
\ No newline at end of file
|
Coverage report
Test suite run success3891 tests passing in 1510 suites. Report generated by 🧪jest coverage report action from 6c8a52b |
ffcfa99 to
0fd3c26
Compare
1d5c873 to
912e7f4
Compare
912e7f4 to
0da8073
Compare
0fd3c26 to
141233b
Compare
0da8073 to
8cc8f2f
Compare
141233b to
06bccee
Compare
8cc8f2f to
5068d26
Compare
d13b2b2 to
ef2ca4e
Compare
5068d26 to
d58c2f4
Compare
ef2ca4e to
9c06d65
Compare
d58c2f4 to
a10faf5
Compare
- Add generateManifest boolean to IncludeAssetsConfigSchema (default false) - Add anchor and groupBy fields to ConfigKeyEntrySchema for grouped manifest entries - Track copy operations in pathMap to resolve output-relative paths - Deduplicate source paths to prevent indexed suffixes on shared files - Use sequential copy loop to prevent findUniqueDestPath race conditions - resolveManifestPaths walks manifest tree using pathMap; non-path strings pass through unchanged - 33 tests passing
- Rename short identifiers (k, v, p) to satisfy id-length rule - Add eslint-disable for intentional no-await-in-loop in sequential copy loop - Add null guard for head in buildRelativeEntry to fix TS18048 - Run prettier fixes
9c06d65 to
6c8a52b
Compare
a10faf5 to
3da8d68
Compare

WHY are these changes introduced?
Fixes #0000
WHAT is this pull request doing?
How to test your changes?
Post-release steps
Measuring impact
How do we know this change was effective? Please choose one:
Checklist