Skip to content

Fix Militant Faith protected nodes not working properly #9609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LocalIdentity merged 1 commit into from
Mar 14, 2026
Merged

Fix Militant Faith protected nodes not working properly #9609

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 13 additions & 7 deletions src/Classes/TreeTab.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2317,7 +2317,11 @@ function TreeTabClass:FindTimelessJewel()
else
local curNode = nil
local curNodeId = nil
if (timelessData.jewelType.id == 4 and isValueInTable(protectedNodes, treeData.nodes[targetNode].dn)) then
if (timelessData.jewelType.id == 4 and isValueInTable(protectedNodes, treeData.nodes[targetNode].dn)) then -- protected
if jewelDataTbl[1] >= data.timelessJewelAdditions then -- protected node is a replacement, invalidate seed
resultNodes[curSeed] = nil
break
end
if not desiredNodes["totalStat"] then -- only add if user has not entered their own Devotion to the table
desiredNodes["totalStat"] = {
nodeWeight = 0.1, -- keeps total score low to let desired stats decide sort
Expand Down Expand Up @@ -2381,7 +2385,7 @@ function TreeTabClass:FindTimelessJewel()
end
end
end
if desiredNodes["totalStat"] then
if resultNodes[curSeed] and desiredNodes["totalStat"] then
resultNodes[curSeed]["totalStat"] = resultNodes[curSeed]["totalStat"] or { targetNodeNames = { }, totalWeight = 0 }
if timelessData.jewelType.id == 4 then -- Militant Faith
local addedWeight = desiredNodes["totalStat"].nodeWeight * (5 * targetSmallNodes.otherSmalls + 10 * targetSmallNodes.attributeSmalls)
Expand All @@ -2395,11 +2399,13 @@ function TreeTabClass:FindTimelessJewel()
seedWeights[curSeed] = seedWeights[curSeed] + addedWeight
end
end
-- check minimum weights
for _, val in ipairs(minimumWeights) do
if (resultNodes[curSeed][val.reqNode] and resultNodes[curSeed][val.reqNode].totalWeight or 0) < val.weight then
resultNodes[curSeed] = nil
break
if resultNodes[curSeed] then
-- check minimum weights
for _, val in ipairs(minimumWeights) do
if (resultNodes[curSeed][val.reqNode] and resultNodes[curSeed][val.reqNode].totalWeight or 0) < val.weight then
resultNodes[curSeed] = nil
break
end
end
end
end
Expand Down
Loading