Fix Militant Faith protected nodes not working properly#9609
Open
LocalIdentity wants to merge 1 commit intodevfrom
Open
Fix Militant Faith protected nodes not working properly#9609LocalIdentity wants to merge 1 commit intodevfrom
LocalIdentity wants to merge 1 commit intodevfrom
Conversation
Protected nodes were not strictly enforced. In some cases results included seeds that replaced a protected notable Protected nodes were being handled as just Devotion stats as there was no explicit seed rejection when the jewel data indicated a replacement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8191
Description of the problem being solved:
Protected nodes were not strictly enforced.
In some cases results included seeds that replaced a protected notable
Protected nodes were being handled as just Devotion stats as there was no explicit seed rejection when the jewel data indicated a replacement
Link to a build that showcases this PR:
https://maxroll.gg/poe/pob/8b17k103
Before screenshot:
After screenshot: