Skip to content

Fix Cryogenesis not working correctly #9603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LocalIdentity merged 1 commit into from
Mar 12, 2026
Merged

Fix Cryogenesis not working correctly #9603

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Classes/CalcsTab.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -614,7 +614,7 @@ function CalcsTabClass:PowerBuilder()
end

function CalcsTabClass:CalculatePowerStat(selection, original, modified)
if modified.Minion and not selection.stat == "FullDPS" then
if modified.Minion and selection.stat ~= "FullDPS" then
original = original.Minion
modified = modified.Minion
end
Expand Down
2 changes: 1 addition & 1 deletion src/Classes/ModStore.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,7 +300,7 @@ function ModStoreClass:GetStat(stat, cfg)
if stat == "ManaUnreserved" and self.actor.output[stat] ~= self.actor.output[stat] then
-- 0% reserved = total mana
return self.actor.output["Mana"]
elseif stat == "ManaUnreserved" and not self.actor.output[stat] == nil and self.actor.output[stat] < 0 then
elseif stat == "ManaUnreserved" and self.actor.output[stat] ~= nil and self.actor.output[stat] < 0 then
-- This reverse engineers how much mana is unreserved before efficiency for accurate Arcane Cloak calcs
local reservedPercentBeforeEfficiency = (math.abs(self.actor.output["ManaUnreservedPercent"]) + 100) * ((100 + self.actor["ManaEfficiency"]) / 100)
return self.actor.output["Mana"] * (math.ceil(reservedPercentBeforeEfficiency) / 100);
Expand Down
2 changes: 1 addition & 1 deletion src/Modules/CalcActiveSkill.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ function calcs.copyActiveSkill(env, mode, skill)
activeEffect.quality = skill.activeEffect.srcInstance.quality
activeEffect.qualityId = skill.activeEffect.srcInstance.qualityId
activeEffect.srcInstance = skill.activeEffect.srcInstance
activeEffect.gemData = skill.activeEffect.srcInstance.gemDat
activeEffect.gemData = skill.activeEffect.srcInstance.gemData
end

local newSkill = calcs.createActiveSkill(activeEffect, skill.supportList, skill.actor, skill.socketGroup, skill.summonSkill)
Expand Down
2 changes: 1 addition & 1 deletion src/Modules/CalcOffence.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3067,7 +3067,7 @@ function calcs.offence(env, actor, activeSkill)
elseif skillModList:Flag(cfg, "AllAddedDamageAsCold") then
addedDamageRedirectType = "Cold"
end
if addedDamageRedirectType and not activeSkill.activeEffect.grantedEffect.name == "Elemental Hit" then
if addedDamageRedirectType and activeSkill.activeEffect.grantedEffect.name ~= "Elemental Hit" then
for _, damageType in ipairs(dmgTypeList) do
if damageType ~= addedDamageRedirectType then
for _, value in ipairs(skillModList:Tabulate("BASE", cfg, damageType.."Min")) do
Expand Down
Loading