Fix Cryogenesis not working correctly#9603
Merged
LocalIdentity merged 1 commit intoPathOfBuildingCommunity:devfrom Mar 12, 2026
Merged
Fix Cryogenesis not working correctly#9603LocalIdentity merged 1 commit intoPathOfBuildingCommunity:devfrom
LocalIdentity merged 1 commit intoPathOfBuildingCommunity:devfrom
Conversation
LocalIdentity
approved these changes
Mar 12, 2026
LocalIdentity
changed the title
LocalIdentity
added
bug: calculation
Closed
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found four definite correctness bugs worth patching immediately. First, CalcActiveSkill.copyActiveSkill assigns activeEffect.gemData = skill.activeEffect.srcInstance.gemDat, which is a typo and should be gemData. That copied-skill path matters because CalcMirages uses calcs.copyActiveSkill(...) before running a recalculation for the mirage skill.
Second, ModStore.lua has a Lua precedence bug: not self.actor.output[stat] == nil is parsed as (not self.actor.output[stat]) == nil, so that branch is effectively dead. The intended condition is self.actor.output[stat] ~= nil. Because that code is in the ManaUnreserved fallback logic, it can suppress the negative-unreserved-mana recovery path.
Third, CalcsTab.lua has the same precedence bug in if modified.Minion and not selection.stat == "FullDPS" then. That should be selection.stat ~= "FullDPS". As written, the minion-switch branch is effectively never taken for normal string values.
Fourth, CalcOffence.lua has the same mistake again: if addedDamageRedirectType and not activeSkill.activeEffect.grantedEffect.name == "Elemental Hit" then. That should be activeSkill.activeEffect.grantedEffect.name ~= "Elemental Hit". In practice, that means the exclusion logic for Elemental Hit is not behaving as intended.