Skip to content

Add test for example and template to be valid frictionless datapackage#305

Draft
Ludee wants to merge 10 commits intodevelopfrom
feature-290-frictionless-test
Draft

Add test for example and template to be valid frictionless datapackage#305
Ludee wants to merge 10 commits intodevelopfrom
feature-290-frictionless-test

Conversation

@Ludee
Copy link
Copy Markdown
Member

@Ludee Ludee commented Apr 9, 2026

Summary of the discussion

Use frictionless-py validate function in tests.

Type of change (CHANGELOG.md)

Added

  • Tests for example and template to be valid frictionless datapackage (#305)

Workflow checklist

Automation

Closes #290 / Part of #296

PR-Assignee

  • 🐙 Follow the workflow in CONTRIBUTING.md
  • 📝 Update the CHANGELOG.md
  • 📙 Update the documentation
  • 🐙 Assign a reviewer to the PR

Reviewer

  • 🐙 Follow the Reviewer Guidelines
  • 🐙 Provided feedback and show sufficient appreciation for the work done

@Ludee Ludee requested a review from jh-RLI April 9, 2026 07:59
@Ludee Ludee self-assigned this Apr 9, 2026
@Ludee Ludee added priority: critical 🔥 Critical priority part: backend 🧱 Backend component type: feature 🛠 New feature or request status: completed ✔️ Task has been completed labels Apr 9, 2026
@Ludee Ludee added status: blocked 🛑 Blocked or impeded progress and removed status: completed ✔️ Task has been completed labels Apr 9, 2026
@Ludee Ludee marked this pull request as draft April 9, 2026 20:07
Copy link
Copy Markdown
Contributor

@jh-RLI jh-RLI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest tp focus on this PR before continuing work on the other "oem content" related PR´s

Most tests are failing as you used "type": "text", instead of "type": "string",

Please also put the option of "null" if a property is not required:

          "type": [
            "string",
            "null"
          ],

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

part: backend 🧱 Backend component priority: critical 🔥 Critical priority status: blocked 🛑 Blocked or impeded progress type: feature 🛠 New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Check if our Dataset is valid agaist frictionless data "Package"

2 participants