Open
Conversation
jh-RLI
approved these changes
Apr 10, 2026
Contributor
jh-RLI
left a comment
There was a problem hiding this comment.
I noticed that starting a new version makes it hard to review the changes. In general - As far as i can see - this looks correct.
As in this PR the test are missing i would suggest to merge the initial version of the release files soon. And then only work on the test in this PR #305 . Once the initial version + tests are merged furhter changes can be integrated in a more save way.
Once the initial version is established in dev mode further changes become more scoped and much easier to review. What do you think @Ludee
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the discussion
The role "Creator" or "DatasetCreator" is not part of the DataCite contributorType. But is completely clear.
Having 3 default entries in the "contributors" section is suggested:
Type of change (CHANGELOG.md)
Added
Workflow checklist
Automation
Part of #296 Closes #293
PR-Assignee
Reviewer