Skip to content

Add the ability to specify a custom source-directory#27

Merged
astrofrog merged 2 commits intoOpenAstronomy:mainfrom
astrofrog:working-directory
Feb 28, 2026
Merged

Add the ability to specify a custom source-directory#27
astrofrog merged 2 commits intoOpenAstronomy:mainfrom
astrofrog:working-directory

Conversation

@astrofrog
Copy link
Contributor

This is useful for e.g. monorepos or in general repositories where the pyproject.toml may not be at the root of the repository

@astrofrog astrofrog marked this pull request as ready for review February 28, 2026 15:46
@astrofrog
Copy link
Contributor Author

I thought maybe build-directory makes more sense so I've changed it to that, but open to suggestions.

@astrofrog astrofrog changed the title Add the ability to specify a custom working directory Add the ability to specify a custom build directory Feb 28, 2026
@astrofrog astrofrog added the enhancement New feature or request label Feb 28, 2026
@ConorMacBride
Copy link
Member

ConorMacBride commented Feb 28, 2026

Good idea! I see the option is called srcdir in the build docs, so maybe source-directory would be fine? build-directory sounds like it could refer to a build/ directory.

(Don't think it should be called working-directory in this repo as it doesn't affect where build artifacts are written to.)

@astrofrog
Copy link
Contributor Author

@ConorMacBride - does this seem ok?

@astrofrog astrofrog changed the title Add the ability to specify a custom build directory Add the ability to specify a custom source directory Feb 28, 2026
@astrofrog astrofrog changed the title Add the ability to specify a custom source directory Add the ability to specify a custom source directory with source-directory Feb 28, 2026
@astrofrog astrofrog changed the title Add the ability to specify a custom source directory with source-directory Add the ability to specify a custom source-directory Feb 28, 2026
Copy link
Member

@ConorMacBride ConorMacBride left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@astrofrog astrofrog merged commit 541e0aa into OpenAstronomy:main Feb 28, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants