Add the ability to specify a custom working directory for tox and custom build directory for publish#358
Merged
astrofrog merged 2 commits intoOpenAstronomy:mainfrom Mar 2, 2026
Conversation
Member
|
I think |
d21ce1c to
d95ee73
Compare
Contributor
Author
|
@ConorMacBride - I think this is ready for review! |
Member
|
This all looks good. We should just specify that |
d95ee73 to
293b81b
Compare
Contributor
Author
|
@ConorMacBride - I think I've addressed your comment |
ConorMacBride
approved these changes
Mar 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This requires OpenAstronomy/build-python-dist#27 so won't work until that's merged.
Note that the option is called
working-directoryfor tox andbuild-directoryfor publish, does that make sense or should we change that?