Skip to content

Add the ability to specify a custom working directory for tox and custom build directory for publish#358

Merged
astrofrog merged 2 commits intoOpenAstronomy:mainfrom
astrofrog:working-directory
Mar 2, 2026
Merged

Add the ability to specify a custom working directory for tox and custom build directory for publish#358
astrofrog merged 2 commits intoOpenAstronomy:mainfrom
astrofrog:working-directory

Conversation

@astrofrog
Copy link
Contributor

This requires OpenAstronomy/build-python-dist#27 so won't work until that's merged.

Note that the option is called working-directory for tox and build-directory for publish, does that make sense or should we change that?

@ConorMacBride
Copy link
Member

I think working-directory would make sense for both workflows, as the default build srcdir is the working directory.

@astrofrog astrofrog force-pushed the working-directory branch 5 times, most recently from d21ce1c to d95ee73 Compare February 28, 2026 22:09
@astrofrog astrofrog marked this pull request as ready for review February 28, 2026 22:13
@astrofrog
Copy link
Contributor Author

@ConorMacBride - I think this is ready for review!

@ConorMacBride
Copy link
Member

This all looks good. We should just specify that working-directory cannot be overwritten per tox environment here beside submodules https://github-actions-workflows--358.org.readthedocs.build/en/358/tox.html#inputs

@astrofrog astrofrog force-pushed the working-directory branch from d95ee73 to 293b81b Compare March 1, 2026 20:01
@astrofrog
Copy link
Contributor Author

@ConorMacBride - I think I've addressed your comment

@astrofrog astrofrog merged commit a138926 into OpenAstronomy:main Mar 2, 2026
105 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants